* Re: [PATCH 1/3] RDMA/irdma: change the returned type of irdma_sc_repost_aeq_entries to void [not found] ` <20210714031130.1511109-2-yanjun.zhu@linux.dev> @ 2021-07-14 9:14 ` Leon Romanovsky 2021-07-14 9:23 ` Zhu Yanjun 0 siblings, 1 reply; 3+ messages in thread From: Leon Romanovsky @ 2021-07-14 9:14 UTC (permalink / raw) To: shiraz.saleem Cc: zyjzyj2000, yanjun.zhu, mustafa.ismail, dledford, jgg, linux-rdma, yanjun.zhu, Jakub Kicinski, linux-netdev On Tue, Jul 13, 2021 at 11:11:28PM -0400, yanjun.zhu@linux.dev wrote: > From: Zhu Yanjun <yanjun.zhu@linux.dev> > > The function irdma_sc_repost_aeq_entries always returns zero. So > the returned type is changed to void. > > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev> > --- > drivers/infiniband/hw/irdma/ctrl.c | 4 +--- > drivers/infiniband/hw/irdma/type.h | 3 +-- > 2 files changed, 2 insertions(+), 5 deletions(-) <...> > -enum irdma_status_code irdma_sc_repost_aeq_entries(struct irdma_sc_dev *dev, > - u32 count); I clearly remember that Jakub asked for more than once to remo remove custom ice/irdma error codes. Did it happen? Can we get rid from them in RDMA too? Thanks ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] RDMA/irdma: change the returned type of irdma_sc_repost_aeq_entries to void 2021-07-14 9:14 ` [PATCH 1/3] RDMA/irdma: change the returned type of irdma_sc_repost_aeq_entries to void Leon Romanovsky @ 2021-07-14 9:23 ` Zhu Yanjun 2021-07-18 9:27 ` Leon Romanovsky 0 siblings, 1 reply; 3+ messages in thread From: Zhu Yanjun @ 2021-07-14 9:23 UTC (permalink / raw) To: Leon Romanovsky Cc: Shiraz Saleem, Zhu Yanjun, mustafa.ismail, Doug Ledford, Jason Gunthorpe, RDMA mailing list, yanjun.zhu, Jakub Kicinski, linux-netdev On Wed, Jul 14, 2021 at 5:15 PM Leon Romanovsky <leon@kernel.org> wrote: > > On Tue, Jul 13, 2021 at 11:11:28PM -0400, yanjun.zhu@linux.dev wrote: > > From: Zhu Yanjun <yanjun.zhu@linux.dev> > > > > The function irdma_sc_repost_aeq_entries always returns zero. So > > the returned type is changed to void. > > > > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev> > > --- > > drivers/infiniband/hw/irdma/ctrl.c | 4 +--- > > drivers/infiniband/hw/irdma/type.h | 3 +-- > > 2 files changed, 2 insertions(+), 5 deletions(-) > > <...> > > > -enum irdma_status_code irdma_sc_repost_aeq_entries(struct irdma_sc_dev *dev, > > - u32 count); > > I clearly remember that Jakub asked for more than once to remo remove > custom ice/irdma error codes. Did it happen? Can we get rid from them > in RDMA too? No. This is not related with custom ice/irdma error codes. This is related with the returned type of the function. If a function always returns 0, change the function returned type to void. And remove the related returned value check. Zhu Yanjun > > Thanks ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] RDMA/irdma: change the returned type of irdma_sc_repost_aeq_entries to void 2021-07-14 9:23 ` Zhu Yanjun @ 2021-07-18 9:27 ` Leon Romanovsky 0 siblings, 0 replies; 3+ messages in thread From: Leon Romanovsky @ 2021-07-18 9:27 UTC (permalink / raw) To: Zhu Yanjun Cc: Shiraz Saleem, Zhu Yanjun, mustafa.ismail, Doug Ledford, Jason Gunthorpe, RDMA mailing list, yanjun.zhu, Jakub Kicinski, linux-netdev On Wed, Jul 14, 2021 at 05:23:33PM +0800, Zhu Yanjun wrote: > On Wed, Jul 14, 2021 at 5:15 PM Leon Romanovsky <leon@kernel.org> wrote: > > > > On Tue, Jul 13, 2021 at 11:11:28PM -0400, yanjun.zhu@linux.dev wrote: > > > From: Zhu Yanjun <yanjun.zhu@linux.dev> > > > > > > The function irdma_sc_repost_aeq_entries always returns zero. So > > > the returned type is changed to void. > > > > > > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev> > > > --- > > > drivers/infiniband/hw/irdma/ctrl.c | 4 +--- > > > drivers/infiniband/hw/irdma/type.h | 3 +-- > > > 2 files changed, 2 insertions(+), 5 deletions(-) > > > > <...> > > > > > -enum irdma_status_code irdma_sc_repost_aeq_entries(struct irdma_sc_dev *dev, > > > - u32 count); > > > > I clearly remember that Jakub asked for more than once to remo remove > > custom ice/irdma error codes. Did it happen? Can we get rid from them > > in RDMA too? > > No. This is not related with custom ice/irdma error codes. I'm not talking about your specific change, but pointed to the fact that custom error codes are not cleaned despite multiple requests. Thanks ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-18 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210714031130.1511109-1-yanjun.zhu@linux.dev>
[not found] ` <20210714031130.1511109-2-yanjun.zhu@linux.dev>
2021-07-14 9:14 ` [PATCH 1/3] RDMA/irdma: change the returned type of irdma_sc_repost_aeq_entries to void Leon Romanovsky
2021-07-14 9:23 ` Zhu Yanjun
2021-07-18 9:27 ` Leon Romanovsky
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).