From: Andrew Lunn <andrew@lunn.ch>
To: Ling Pei Lee <pei.lee.ling@intel.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
davem@davemloft.net, Jakub Kicinski <kuba@kernel.org>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
weifeng.voon@intel.com, vee.khee.wong@linux.intel.com,
vee.khee.wong@intel.com, mohammad.athari.ismail@intel.com
Subject: Re: [PATCH net] net: phy: skip disabling interrupt when WOL is enabled in shutdown
Date: Tue, 6 Jul 2021 15:14:25 +0200 [thread overview]
Message-ID: <YORXMSmvqwYg7QA9@lunn.ch> (raw)
In-Reply-To: <20210706090209.1897027-1-pei.lee.ling@intel.com>
On Tue, Jul 06, 2021 at 05:02:09PM +0800, Ling Pei Lee wrote:
> From: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
>
> PHY WOL requires WOL interrupt event to trigger the WOL signal
> in order to wake up the system. Hence, the PHY driver should not
> disable the interrupt during shutdown if PHY WOL is enabled.
If the device is being used to wake the system up, why is it being
shutdown?
Andrew
next prev parent reply other threads:[~2021-07-06 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 9:02 [PATCH net] net: phy: skip disabling interrupt when WOL is enabled in shutdown Ling Pei Lee
2021-07-06 13:14 ` Andrew Lunn [this message]
2021-07-07 0:36 ` Ismail, Mohammad Athari
2021-07-07 0:57 ` Andrew Lunn
2021-07-07 2:51 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YORXMSmvqwYg7QA9@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mohammad.athari.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pei.lee.ling@intel.com \
--cc=vee.khee.wong@intel.com \
--cc=vee.khee.wong@linux.intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).