From: Jiri Pirko <jiri@resnulli.us>
To: davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
mlxsw@nvidia.com
Subject: Re: [patch net-next v2] devlink: append split port number to the port name
Date: Fri, 23 Jul 2021 11:33:36 +0200 [thread overview]
Message-ID: <YPqM8HUUsl1n0RKD@nanopsycho> (raw)
In-Reply-To: <162215100360.12583.10419235646821072826.git-patchwork-notify@kernel.org>
Thu, May 27, 2021 at 11:30:03PM CEST, patchwork-bot+netdevbpf@kernel.org wrote:
>Hello:
>
>This patch was applied to netdev/net-next.git (refs/heads/master):
>
>On Thu, 27 May 2021 12:48:19 +0200 you wrote:
>> From: Jiri Pirko <jiri@nvidia.com>
>>
>> Instead of doing sprintf twice in case the port is split or not, append
>> the split port suffix in case the port is split.
>>
>> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
>>
>> [...]
>
>Here is the summary with links:
> - [net-next,v2] devlink: append split port number to the port name
> https://git.kernel.org/netdev/net-next/c/f285f37cb1e6
>
>You are awesome, thank you!
Something wrong happened. The patch was applied but eventually, the
removed lines are back:
acf1ee44ca5da (Parav Pandit 2020-03-03 08:12:42 -0600 9331) case DEVLINK_PORT_FLAVOUR_VIRTUAL:
f285f37cb1e6b (Jiri Pirko 2021-05-27 12:48:19 +0200 9332) n = snprintf(name, len, "p%u", attrs->phys.port_number);
f285f37cb1e6b (Jiri Pirko 2021-05-27 12:48:19 +0200 9333) if (n < len && attrs->split)
f285f37cb1e6b (Jiri Pirko 2021-05-27 12:48:19 +0200 9334) n += snprintf(name + n, len - n, "s%u",
f285f37cb1e6b (Jiri Pirko 2021-05-27 12:48:19 +0200 9335) attrs->phys.split_subport_number);
08474c1a9df0c (Jiri Pirko 2018-05-18 09:29:02 +0200 9336) if (!attrs->split)
378ef01b5f75e (Parav Pandit 2019-07-08 23:17:35 -0500 9337) n = snprintf(name, len, "p%u", attrs->phys.port_number);
08474c1a9df0c (Jiri Pirko 2018-05-18 09:29:02 +0200 9338) else
378ef01b5f75e (Parav Pandit 2019-07-08 23:17:35 -0500 9339) n = snprintf(name, len, "p%us%u",
378ef01b5f75e (Parav Pandit 2019-07-08 23:17:35 -0500 9340) attrs->phys.port_number,
378ef01b5f75e (Parav Pandit 2019-07-08 23:17:35 -0500 9341) attrs->phys.split_subport_number);
126285651b7f9 (David S. Miller 2021-06-07 13:01:52 -0700 9342)
08474c1a9df0c (Jiri Pirko 2018-05-18 09:29:02 +0200 9343) break;
If I do "git reset --hard f285f37cb1e6b", everything is looking fine,
in the current net-next, the removed lines are still present :O
I see ghosts...
Could you check & fix?
next prev parent reply other threads:[~2021-07-23 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 10:48 [patch net-next v2] devlink: append split port number to the port name Jiri Pirko
2021-05-27 21:30 ` patchwork-bot+netdevbpf
2021-07-23 9:33 ` Jiri Pirko [this message]
2021-07-30 12:18 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPqM8HUUsl1n0RKD@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox