From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
David Miller <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
"Cong Wang ." <cong.wang@bytedance.com>,
Peilin Ye <peilin.ye@bytedance.com>
Subject: Re: [PATCH net-next] Revert "netdevsim: Add multi-queue support"
Date: Wed, 4 Aug 2021 10:14:36 +0300 [thread overview]
Message-ID: <YQo+XJQNAP7jnGw0@unreal> (raw)
In-Reply-To: <20210803145124.71a8aab4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Tue, Aug 03, 2021 at 02:51:24PM -0700, Jakub Kicinski wrote:
> On Tue, 3 Aug 2021 14:32:19 -0700 Cong Wang wrote:
> > On Tue, Aug 3, 2021 at 2:18 PM Jakub Kicinski <kuba@kernel.org> wrote:
<...>
> > Please remove all those not covered by upstream tests just to be fair??
>
> I'd love to remove all test harnesses upstream which are not used by
> upstream tests, sure :)
Jakub,
Something related and unrelated at the same time.
I need to get rid of devlink_reload_enable()/_disable() to fix some
panics in the devlink reload flow.
Such change is relatively easy for the HW drivers, but not so for the
netdevism due to attempt to synchronize sysfs with devlink.
200 mutex_lock(&nsim_bus_dev->nsim_bus_reload_lock);
201 devlink_reload_disable(devlink);
202 ret = nsim_dev_port_add(nsim_bus_dev, NSIM_DEV_PORT_TYPE_PF, port_index);
203 devlink_reload_enable(devlink);
204 mutex_unlock(&nsim_bus_dev->nsim_bus_reload_lock);
Are these sysfs files declared as UAPI? Or can I update upstream test
suite and delete them safely?
Thanks
next prev parent reply other threads:[~2021-08-04 7:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 12:39 [PATCH net-next] Revert "netdevsim: Add multi-queue support" Jakub Kicinski
2021-08-03 17:11 ` Cong Wang
2021-08-03 21:18 ` Jakub Kicinski
2021-08-03 21:32 ` Cong Wang
2021-08-03 21:51 ` Jakub Kicinski
2021-08-03 22:04 ` Cong Wang
2021-08-04 7:14 ` Leon Romanovsky [this message]
2021-08-04 11:52 ` Jakub Kicinski
2021-08-04 12:49 ` Leon Romanovsky
2021-08-04 15:56 ` Jakub Kicinski
2021-08-04 17:25 ` Leon Romanovsky
2021-08-03 22:16 ` [PATCH net-next] tc-testing: Add control-plane selftests for sch_mq Peilin Ye
2021-08-03 22:21 ` Cong Wang
2021-08-04 11:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQo+XJQNAP7jnGw0@unreal \
--to=leon@kernel.org \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peilin.ye@bytedance.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).