From: Andrew Lunn <andrew@lunn.ch>
To: Stephen Suryaputra <ssuryaextr@gmail.com>
Cc: Nikolay Aleksandrov <nikolay@nvidia.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipmr: ip6mr: Add ability to display non default caches and vifs
Date: Thu, 19 Aug 2021 01:09:15 +0200 [thread overview]
Message-ID: <YR2TG2uodH4wHM1/@lunn.ch> (raw)
In-Reply-To: <20210818225022.GA31396@ICIPI.localdomain>
On Wed, Aug 18, 2021 at 06:50:22PM -0400, Stephen Suryaputra wrote:
> On Thu, Aug 19, 2021 at 01:37:21AM +0300, Nikolay Aleksandrov wrote:
> >
> > Sorry, but I don't see any point to this. We don't have it for any of the other
> > non-default cases, and I don't see a point of having it for ipmr either.
> > If you'd like to display the non-default tables then you query for them, you
> > don't change a sysctl to see them in /proc.
> > It sounds like a workaround for an issue that is not solved properly, and
> > generally it shouldn't be using /proc. If netlink interfaces are not sufficient
> > please improve them.
>
> We found that the ability to dump the tables from kernel point of view
> is valuable for debugging the applications. Sometimes during the
> development, bugs in the use of the netlink interfaces can be solved
> quickly if the tables in the kernel can be viewed easily.
>
> If you agree on the reasoning above, what do you recommend then? Again,
> this is to easily view what's in the kernel.
Does iproute2 allow you to dump the tables?
First work on a simple CLI tool to dump the tables. Make it bug free
and contribute it. Then work on your buggy multicast routing daemon.
Andrew
next prev parent reply other threads:[~2021-08-18 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 20:09 [PATCH net-next] ipmr: ip6mr: Add ability to display non default caches and vifs Stephen Suryaputra
2021-08-18 22:37 ` Nikolay Aleksandrov
2021-08-18 22:50 ` Stephen Suryaputra
2021-08-18 23:09 ` Andrew Lunn [this message]
2021-08-18 23:12 ` Nikolay Aleksandrov
2021-08-19 0:04 ` David Ahern
2021-09-20 23:49 ` Stephen Suryaputra
2021-09-21 7:43 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR2TG2uodH4wHM1/@lunn.ch \
--to=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=ssuryaextr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).