From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A94BC4338F for ; Wed, 11 Aug 2021 21:04:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CF9A6104F for ; Wed, 11 Aug 2021 21:04:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231927AbhHKVEv (ORCPT ); Wed, 11 Aug 2021 17:04:51 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33771 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbhHKVEu (ORCPT ); Wed, 11 Aug 2021 17:04:50 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 368B25C00C4; Wed, 11 Aug 2021 17:04:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 11 Aug 2021 17:04:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=QgBhEM WhLuteJtYyzx8a0OGrYC8CjFmeV/TwKZUZ8Do=; b=vp1VZWvZIFgKH0jrCc4XjA 9Yd9+cB2s9uRR4t28PUzIZgdYT7kw0ZHyz8qGCFCe+Mt4kk6rdJYBBQhzU4E/13A Zu+LVstRdZJ0Loy1CdYRelDs2Lnc/woBCXp2wxwyM/IqfIWQFVFEZ34nXF5hsnG2 7buta3fYVterCpS9Nwz4wLoZnsiHVbqdiKWheVz/ksklBeYORXmM/w8mf/AbzxfF /UfozTDYlKUVlf+85KREn11tUgBnyX0/Imi3us1jrHEakGjzLqO+j3mth94oAYFn 4JFB2YRwy/8RmWp8Vpd+17neXVxoLRaNbYhkoFvOO0suSzC2cgQt3448yRXymAOQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrkedugdduheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedtffekkeefudffveegueejffejhfetgfeuuefgvedtieehudeuueekhfduheel teenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiug hoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 Aug 2021 17:04:23 -0400 (EDT) Date: Thu, 12 Aug 2021 00:04:19 +0300 From: Ido Schimmel To: Jakub Kicinski Cc: Andrew Lunn , "Keller, Jacob E" , netdev@vger.kernel.org, davem@davemloft.net, mkubecek@suse.cz, pali@kernel.org, vadimp@nvidia.com, mlxsw@nvidia.com, Ido Schimmel Subject: Re: [RFC PATCH net-next 1/8] ethtool: Add ability to control transceiver modules' low power mode Message-ID: References: <20210810065954.68036568@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210810150544.3fec5086@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210811060343.014724e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210811133006.1c9aa6db@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210811133006.1c9aa6db@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 11, 2021 at 01:30:06PM -0700, Jakub Kicinski wrote: > Isn't the "low-power" attr just duplicating the relevant bits from -m? If low power is forced by hardware, then it depends on the assertion / de-assertion of the hardware signal which is obviously not part of the EEPROM dump. I knew this would come up, so I mentioned it in the commit message: "The low power mode can be queried from the kernel. In case LowPwrAllowRequestHW was on, the kernel would need to take into account the state of the LowPwrRequestHW signal, which is not visible to user space."