netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andreas Hilse <andreas.hilse@googlemail.com>
Cc: Bryan Whitehead <bryan.whitehead@microchip.com>,
	UNGLinuxDriver@microchip.com, netdev@vger.kernel.org
Subject: Re: lan743x driver fails to map DMA during initialization on Raspberry CM4IO
Date: Sun, 15 Aug 2021 09:42:09 +0100	[thread overview]
Message-ID: <YRjTYUykl+4/KAXv@infradead.org> (raw)
In-Reply-To: <CANabuZeqrpk-gsZnCz-CYZKo5pRfWW0MGSY2DAWqz1060bReGw@mail.gmail.com>

On Mon, Aug 02, 2021 at 02:45:12PM +0200, Andreas Hilse wrote:
> +
> +       if (dma_set_mask_and_coherent(&rx->adapter->pdev->dev,
> DMA_BIT_MASK(64))) {

Setting the 64-bit mask never fails, no need for the error handling
here.

      reply	other threads:[~2021-08-15  8:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 12:45 lan743x driver fails to map DMA during initialization on Raspberry CM4IO Andreas Hilse
2021-08-15  8:42 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRjTYUykl+4/KAXv@infradead.org \
    --to=hch@infradead.org \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andreas.hilse@googlemail.com \
    --cc=bryan.whitehead@microchip.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).