From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B24BDC4320E for ; Mon, 30 Aug 2021 13:51:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93F9660E98 for ; Mon, 30 Aug 2021 13:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236974AbhH3Nwo (ORCPT ); Mon, 30 Aug 2021 09:52:44 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48492 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236858AbhH3Nwn (ORCPT ); Mon, 30 Aug 2021 09:52:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=9DGgUo2ugpU41hWzsW/N+Nu2joYqP2tCgM60Nh03GC4=; b=5s k1rHmyE1QQyrq2xcPMU4SNSmqh6fo9dEbWF93Jp0v7TVuONsN3mymtZ5402qJJqOA6wYl+dU3rF4b 7fZNkMa8OnIljxahEh2iQgv86oEdlcNqO4qXrZf6bHsAgh6fGJKPX1/WIXUmLRm5W/hgRmCiGbHtw 66SIBCBvyOzFur8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mKhh7-004ZKf-EG; Mon, 30 Aug 2021 15:51:25 +0200 Date: Mon, 30 Aug 2021 15:51:25 +0200 From: Andrew Lunn To: =?utf-8?B?Q2zDqW1lbnQgQsWTc2No?= Cc: Heiner Kallweit , "David S. Miller" , Jakub Kicinski , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Willy Liu , netdev@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: sunxi H5 DTB fix for realtek regression Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 30, 2021 at 02:52:57AM +0200, Clément Bœsch wrote: > Hi, > > Commit bbc4d71d63549bcd003a430de18a72a742d8c91e ("net: phy: realtek: fix > rtl8211e rx/tx delay config") broke the network on the NanoPI NEO 2 board > (RTL8211E chip). > > Following what was suggested by Andrew Lunn for another hardware¹, I tried > the following diff: > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts > index 02f8e72f0cad..05486cccee1c 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts > @@ -75,7 +75,7 @@ &emac { > pinctrl-0 = <&emac_rgmii_pins>; > phy-supply = <®_gmac_3v3>; > phy-handle = <&ext_rgmii_phy>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-id"; > status = "okay"; > }; > > > ...which fixed the issue. This was tested on v5.11.4 but the patch applies > cleanly on stable so far. > > I'm sorry for not sending a proper patch: I unfortunately have very little > clue about what I'm doing here so it's very hard for me to elaborate a > proper commit description. Hi Clément You are not too far away from a proper patch. I can either guide you, if you want to learn, or the allwinner maintainer can probably take your work and finish it off. Andrew