From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D77E3C4320A for ; Mon, 30 Aug 2021 14:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B74606023E for ; Mon, 30 Aug 2021 14:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237090AbhH3OgG (ORCPT ); Mon, 30 Aug 2021 10:36:06 -0400 Received: from laubervilliers-656-1-228-164.w92-154.abo.wanadoo.fr ([92.154.28.164]:53938 "EHLO ssq0.pkh.me" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237084AbhH3OgD (ORCPT ); Mon, 30 Aug 2021 10:36:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pkh.me; s=selector1; t=1630334107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kgxy1yAh7dMUGFIGxX89+EstgFdP9XB/Xv6c2oPXvCw=; b=F7Eq76EXP+tRVI3tVHAQ9/JIeWcuVUHmCGaV/DjpG5D8KhXnVfpLbeM9bALMOyX8moBUyk QQauk4tiRdyliOgNe9k/O0iwVgJN/vYlACOFy+yalLb1eaLfksTnU4TgT++Phdh+TzQ7cw zvnbYXKdWu91zrTEiQyfFs6CxZsw/es= Received: from localhost (ssq0.pkh.me [local]) by ssq0.pkh.me (OpenSMTPD) with ESMTPA id 680a0b7d; Mon, 30 Aug 2021 14:35:07 +0000 (UTC) Date: Mon, 30 Aug 2021 16:35:07 +0200 From: =?utf-8?B?Q2zDqW1lbnQgQsWTc2No?= To: Andrew Lunn Cc: Heiner Kallweit , "David S. Miller" , Jakub Kicinski , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Willy Liu , netdev@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: sunxi H5 DTB fix for realtek regression Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="yBy1AuXrmCsyj5+w" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --yBy1AuXrmCsyj5+w Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Aug 30, 2021 at 03:51:25PM +0200, Andrew Lunn wrote: [...] > > I'm sorry for not sending a proper patch: I unfortunately have very little > > clue about what I'm doing here so it's very hard for me to elaborate a > > proper commit description. > > Hi Clément > > You are not too far away from a proper patch. I can either guide you, > if you want to learn, or the allwinner maintainer can probably take > your work and finish it off. See attached patch, heavily based on other commits. Note: running `git grep 'phy-mode\s*=\s*"rgmii"' arch` shows that it might affect other hardware as well. I don't know how one is supposed to check that, but I would guess at least sun50i-a64-nanopi-a64.dts is affected (a quick internet search shows that it's using a RTL8211E¹) The grep returns 231 occurences... A lot of other boards might have a broken network right now. [1]: http://nanopi.io/nanopi-a64.html -- Clément B. --yBy1AuXrmCsyj5+w Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-arm64-dts-sun50i-h5-NanoPI-Neo-2-phy-mode-rgmii-id.patch" >From 771f3ad9f8749dd29039a623b25feb818f182104 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= Date: Mon, 30 Aug 2021 16:28:08 +0200 Subject: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") network is broken on the NanoPi Neo 2. This patch changes the phy-mode to use internal delays both for RX and TX as has been done for other boards affected by the same commit. Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") --- arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts index 02f8e72f0cad..05486cccee1c 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts @@ -75,7 +75,7 @@ &emac { pinctrl-0 = <&emac_rgmii_pins>; phy-supply = <®_gmac_3v3>; phy-handle = <&ext_rgmii_phy>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; status = "okay"; }; -- 2.33.0 --yBy1AuXrmCsyj5+w--