* [PATCH -net] ptp: dp83640: don't define PAGE0
@ 2021-09-13 22:06 Randy Dunlap
2021-09-14 0:24 ` Andrew Lunn
2021-09-15 3:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-09-13 22:06 UTC (permalink / raw)
To: netdev
Cc: Randy Dunlap, Geert Uytterhoeven, Richard Cochran, John Stultz,
David S. Miller, Jakub Kicinski, Andrew Lunn, Heiner Kallweit,
Russell King
Building dp83640.c on arch/parisc/ produces a build warning for
PAGE0 being redefined. Since the macro is not used in the dp83640
driver, just make it a comment for documentation purposes.
In file included from ../drivers/net/phy/dp83640.c:23:
../drivers/net/phy/dp83640_reg.h:8: warning: "PAGE0" redefined
8 | #define PAGE0 0x0000
from ../drivers/net/phy/dp83640.c:11:
../arch/parisc/include/asm/page.h:187: note: this is the location of the previous definition
187 | #define PAGE0 ((struct zeropage *)__PAGE_OFFSET)
Fixes: cb646e2b02b2 ("ptp: Added a clock driver for the National Semiconductor PHYTER.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Richard Cochran <richard.cochran@omicron.at>
Cc: John Stultz <john.stultz@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
---
drivers/net/phy/dp83640_reg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20210913.orig/drivers/net/phy/dp83640_reg.h
+++ linux-next-20210913/drivers/net/phy/dp83640_reg.h
@@ -5,7 +5,7 @@
#ifndef HAVE_DP83640_REGISTERS
#define HAVE_DP83640_REGISTERS
-#define PAGE0 0x0000
+/* #define PAGE0 0x0000 */
#define PHYCR2 0x001c /* PHY Control Register 2 */
#define PAGE4 0x0004
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -net] ptp: dp83640: don't define PAGE0
2021-09-13 22:06 [PATCH -net] ptp: dp83640: don't define PAGE0 Randy Dunlap
@ 2021-09-14 0:24 ` Andrew Lunn
2021-09-15 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2021-09-14 0:24 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev, Geert Uytterhoeven, Richard Cochran, John Stultz,
David S. Miller, Jakub Kicinski, Heiner Kallweit, Russell King
On Mon, Sep 13, 2021 at 03:06:05PM -0700, Randy Dunlap wrote:
> Building dp83640.c on arch/parisc/ produces a build warning for
> PAGE0 being redefined. Since the macro is not used in the dp83640
> driver, just make it a comment for documentation purposes.
>
> In file included from ../drivers/net/phy/dp83640.c:23:
> ../drivers/net/phy/dp83640_reg.h:8: warning: "PAGE0" redefined
> 8 | #define PAGE0 0x0000
> from ../drivers/net/phy/dp83640.c:11:
> ../arch/parisc/include/asm/page.h:187: note: this is the location of the previous definition
> 187 | #define PAGE0 ((struct zeropage *)__PAGE_OFFSET)
>
> Fixes: cb646e2b02b2 ("ptp: Added a clock driver for the National Semiconductor PHYTER.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Richard Cochran <richard.cochran@omicron.at>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Russell King <linux@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -net] ptp: dp83640: don't define PAGE0
2021-09-13 22:06 [PATCH -net] ptp: dp83640: don't define PAGE0 Randy Dunlap
2021-09-14 0:24 ` Andrew Lunn
@ 2021-09-15 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-15 3:10 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev, geert, richard.cochran, john.stultz, davem, kuba, andrew,
hkallweit1, linux
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Mon, 13 Sep 2021 15:06:05 -0700 you wrote:
> Building dp83640.c on arch/parisc/ produces a build warning for
> PAGE0 being redefined. Since the macro is not used in the dp83640
> driver, just make it a comment for documentation purposes.
>
> In file included from ../drivers/net/phy/dp83640.c:23:
> ../drivers/net/phy/dp83640_reg.h:8: warning: "PAGE0" redefined
> 8 | #define PAGE0 0x0000
> from ../drivers/net/phy/dp83640.c:11:
> ../arch/parisc/include/asm/page.h:187: note: this is the location of the previous definition
> 187 | #define PAGE0 ((struct zeropage *)__PAGE_OFFSET)
>
> [...]
Here is the summary with links:
- [-net] ptp: dp83640: don't define PAGE0
https://git.kernel.org/netdev/net/c/7366c23ff492
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-15 3:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-13 22:06 [PATCH -net] ptp: dp83640: don't define PAGE0 Randy Dunlap
2021-09-14 0:24 ` Andrew Lunn
2021-09-15 3:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).