From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>,
Vladimir Oltean <olteanv@gmail.com>,
"peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
"joabreu@synopsys.com" <joabreu@synopsys.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH] net: stmmac: fix MAC not working when system resume back with WoL enabled
Date: Mon, 6 Sep 2021 15:23:49 +0200 [thread overview]
Message-ID: <YTYWZaVJoETikxeF@lunn.ch> (raw)
In-Reply-To: <YTX515RMVNmT4q+o@shell.armlinux.org.uk>
> We do have the ability to place the link into the slowest mutually
> supported speed via phy(link)?_speed_down(). This has the advantage of
> reducing the power used to keep the link active while in suspend (which
> is its primary purpose) but also reduces the possible link modes that
> could be autonegotiated with the partner.
>
> I think I'd suggest to Andrew that phy_speed_down() should only
> advertise one capability, not "everything we support below the minimum
> mutually supported capability" - that way, if a link change is attempted
> on the partner while the system is suspended, the link will not come up
> and its obvious it isn't going to work.
Yes, that sounds reasonable.
> I think this is an issue for a separate patch set.
Yes, i would say a change like that is net-next material.
Andrew
next prev parent reply other threads:[~2021-09-06 13:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 9:02 [PATCH] net: stmmac: fix MAC not working when system resume back with WoL enabled Joakim Zhang
2021-09-01 9:13 ` Russell King (Oracle)
2021-09-01 10:21 ` Joakim Zhang
2021-09-01 12:56 ` Russell King (Oracle)
2021-09-02 7:01 ` Joakim Zhang
2021-09-01 15:40 ` Heiner Kallweit
2021-09-02 7:35 ` Joakim Zhang
2021-09-01 9:21 ` Vladimir Oltean
2021-09-01 10:25 ` Joakim Zhang
2021-09-01 10:56 ` Vladimir Oltean
2021-09-01 11:42 ` Joakim Zhang
2021-09-01 13:25 ` Russell King (Oracle)
2021-09-02 7:28 ` Joakim Zhang
2021-09-02 8:32 ` Russell King (Oracle)
2021-09-02 10:26 ` Joakim Zhang
2021-09-02 10:49 ` Russell King (Oracle)
2021-09-02 11:15 ` Joakim Zhang
2021-09-02 12:24 ` Andrew Lunn
2021-09-03 6:51 ` Joakim Zhang
2021-09-03 8:01 ` Russell King (Oracle)
2021-09-03 8:39 ` Joakim Zhang
2021-09-03 9:32 ` Russell King (Oracle)
2021-09-03 11:04 ` Joakim Zhang
2021-09-03 12:01 ` Russell King (Oracle)
2021-09-03 20:12 ` Russell King - ARM Linux admin
2021-09-06 2:29 ` Joakim Zhang
2021-09-06 9:34 ` Russell King (Oracle)
2021-09-06 10:41 ` Joakim Zhang
2021-09-06 11:21 ` Russell King (Oracle)
2021-09-06 13:23 ` Andrew Lunn [this message]
2021-09-07 8:52 ` Russell King (Oracle)
2021-09-06 2:21 ` Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTYWZaVJoETikxeF@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).