From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org, brouer@redhat.com,
davem@davemloft.net, kuba@kernel.org, ast@kernel.org,
daniel@iogearbox.net, shayagr@amazon.com,
john.fastabend@gmail.com, dsahern@kernel.org,
echaudro@redhat.com, jasowang@redhat.com,
alexander.duyck@gmail.com, saeed@kernel.org,
maciej.fijalkowski@intel.com, magnus.karlsson@intel.com,
tirthendu.sarkar@intel.com, toke@redhat.com
Subject: Re: [PATCH v13 bpf-next 01/18] net: skbuff: add size metadata to skb_shared_info for xdp
Date: Tue, 7 Sep 2021 16:45:28 +0200 [thread overview]
Message-ID: <YTd7CGY9Dwm/2cfm@lore-desk> (raw)
In-Reply-To: <2bfd067e-a5aa-29ad-7b3c-0f8af61422ad@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1712 bytes --]
>
>
> On 07/09/2021 14.35, Lorenzo Bianconi wrote:
> > Introduce xdp_frags_tsize field in skb_shared_info data structure
> > to store xdp_buff/xdp_frame truesize (xdp_frags_tsize will be used
> > in xdp multi-buff support). In order to not increase skb_shared_info
> > size we will use a hole due to skb_shared_info alignment.
> > Introduce xdp_frags_size field in skb_shared_info data structure
> > reusing gso_type field in order to store xdp_buff/xdp_frame paged size.
> > xdp_frags_size will be used in xdp multi-buff support.
> >
> > Acked-by: John Fastabend <john.fastabend@gmail.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > include/linux/skbuff.h | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> > index 6bdb0db3e825..1abeba7ef82e 100644
> > --- a/include/linux/skbuff.h
> > +++ b/include/linux/skbuff.h
> > @@ -522,13 +522,17 @@ struct skb_shared_info {
> > unsigned short gso_segs;
> > struct sk_buff *frag_list;
> > struct skb_shared_hwtstamps hwtstamps;
> > - unsigned int gso_type;
> > + union {
> > + unsigned int gso_type;
> > + unsigned int xdp_frags_size;
> > + };
> > u32 tskey;
> > /*
> > * Warning : all fields before dataref are cleared in __alloc_skb()
> > */
> > atomic_t dataref;
> > + unsigned int xdp_frags_tsize;
>
> I wonder if we could call this variable: xdp_frags_truesize.
>
> As while reviewing patches I had to focus my eyes extra hard to tell the
> variables xdp_frags_size and xdp_frags_tsize from each-other.
sure, I will fix it in v14.
Regards,
Lorenzo
>
> --Jesper
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-09-07 14:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 12:35 [PATCH v13 bpf-next 00/18] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 01/18] net: skbuff: add size metadata to skb_shared_info for xdp Lorenzo Bianconi
2021-09-07 14:39 ` Jesper Dangaard Brouer
2021-09-07 14:45 ` Lorenzo Bianconi [this message]
2021-09-07 12:35 ` [PATCH v13 bpf-next 02/18] xdp: introduce flags field in xdp_buff/xdp_frame Lorenzo Bianconi
2021-09-07 14:31 ` Jesper Dangaard Brouer
2021-09-07 14:46 ` Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 03/18] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 04/18] net: mvneta: simplify mvneta_swbm_add_rx_fragment management Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 05/18] net: xdp: add xdp_update_skb_shared_info utility routine Lorenzo Bianconi
2021-09-07 13:40 ` Jesper Dangaard Brouer
2021-09-07 13:44 ` Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 06/18] net: marvell: rely on " Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 07/18] xdp: add multi-buff support to xdp_return_{buff/frame} Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 08/18] net: mvneta: add multi buffer support to XDP_TX Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 09/18] net: mvneta: enable jumbo frames for XDP Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 10/18] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 11/18] bpf: introduce bpf_xdp_get_buff_len helper Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 12/18] bpf: add multi-buffer support to xdp copy helpers Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 13/18] bpf: move user_size out of bpf_test_init Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 14/18] bpf: introduce multibuff support to bpf_prog_test_run_xdp() Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 15/18] bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 16/18] bpf: update xdp_adjust_tail selftest to include multi-buffer Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 17/18] net: xdp: introduce bpf_xdp_adjust_data helper Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 18/18] bpf: add bpf_xdp_adjust_data selftest Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTd7CGY9Dwm/2cfm@lore-desk \
--to=lorenzo.bianconi@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=echaudro@redhat.com \
--cc=jasowang@redhat.com \
--cc=jbrouer@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=shayagr@amazon.com \
--cc=tirthendu.sarkar@intel.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox