From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
davem@davemloft.net, kuba@kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH net] sctp: break out if skb_header_pointer returns NULL in sctp_rcv_ootb
Date: Thu, 23 Sep 2021 22:52:11 -0300 [thread overview]
Message-ID: <YU0vSytl5kjXYe9k@t14s.localdomain> (raw)
In-Reply-To: <8f91703995c8de638695e330c06d17ecec8c9135.1632369904.git.lucien.xin@gmail.com>
On Thu, Sep 23, 2021 at 12:05:04AM -0400, Xin Long wrote:
> We should always check if skb_header_pointer's return is NULL before
> using it, otherwise it may cause null-ptr-deref, as syzbot reported:
>
> KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
> RIP: 0010:sctp_rcv_ootb net/sctp/input.c:705 [inline]
> RIP: 0010:sctp_rcv+0x1d84/0x3220 net/sctp/input.c:196
> Call Trace:
> <IRQ>
> sctp6_rcv+0x38/0x60 net/sctp/ipv6.c:1109
> ip6_protocol_deliver_rcu+0x2e9/0x1ca0 net/ipv6/ip6_input.c:422
> ip6_input_finish+0x62/0x170 net/ipv6/ip6_input.c:463
> NF_HOOK include/linux/netfilter.h:307 [inline]
> NF_HOOK include/linux/netfilter.h:301 [inline]
> ip6_input+0x9c/0xd0 net/ipv6/ip6_input.c:472
> dst_input include/net/dst.h:460 [inline]
> ip6_rcv_finish net/ipv6/ip6_input.c:76 [inline]
> NF_HOOK include/linux/netfilter.h:307 [inline]
> NF_HOOK include/linux/netfilter.h:301 [inline]
> ipv6_rcv+0x28c/0x3c0 net/ipv6/ip6_input.c:297
>
> Fixes: 3acb50c18d8d ("sctp: delay as much as possible skb_linearize")
> Reported-by: syzbot+581aff2ae6b860625116@syzkaller.appspotmail.com
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
next prev parent reply other threads:[~2021-09-24 1:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 4:05 [PATCH net] sctp: break out if skb_header_pointer returns NULL in sctp_rcv_ootb Xin Long
2021-09-24 1:52 ` Marcelo Ricardo Leitner [this message]
2021-09-24 9:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YU0vSytl5kjXYe9k@t14s.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox