From: Andrew Lunn <andrew@lunn.ch>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH 2/3] net: phy: at803x: add resume/suspend function to qca83xx phy
Date: Sun, 19 Sep 2021 18:44:12 +0200 [thread overview]
Message-ID: <YUdo3G1XdxdSv4Fa@lunn.ch> (raw)
In-Reply-To: <20210919151146.10501-2-ansuelsmth@gmail.com>
> +static int qca83xx_suspend(struct phy_device *phydev)
> +{
> + phy_modify(phydev, MII_BMCR, 0, BMCR_PDOWN);
> +
> + return 0;
> +}
> +
> +static int qca83xx_resume(struct phy_device *phydev)
> +{
> + return phy_modify(phydev, MII_BMCR, BMCR_PDOWN, 0);
> +}
> +
genphy_suspend() and genphy_resume() do exactly this. Please use the
helpers.
Please also add a patch 0/3 which explains the big picture. It will be
used in the merge commit.
Andrew
next prev parent reply other threads:[~2021-09-19 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 15:11 [net-next PATCH 1/3] net: phy: at803x: add support for qca 8327 A variant internal phy Ansuel Smith
2021-09-19 15:11 ` [net-next PATCH 2/3] net: phy: at803x: add resume/suspend function to qca83xx phy Ansuel Smith
2021-09-19 16:44 ` Andrew Lunn [this message]
2021-09-19 15:11 ` [net-next PATCH 3/3] net: phy: at803x: fix spacing and improve name for 83xx phy Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUdo3G1XdxdSv4Fa@lunn.ch \
--to=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).