From: Ido Schimmel <idosch@idosch.org>
To: Maciej Machnikowski <maciej.machnikowski@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
richardcochran@gmail.com, abyagowi@fb.com,
anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] ice: add support for reading SyncE DPLL state
Date: Tue, 21 Sep 2021 16:25:54 +0300 [thread overview]
Message-ID: <YUndYq8EcpyPnPud@shredder> (raw)
In-Reply-To: <20210903151436.529478-3-maciej.machnikowski@intel.com>
On Fri, Sep 03, 2021 at 05:14:36PM +0200, Maciej Machnikowski wrote:
> Implement SyncE DPLL monitoring for E810-T devices.
> Poll loop will periodically check the state of the DPLL and cache it
> in the pf structure. State changes will be logged in the system log.
>
> Cached state can be read using the RTM_GETEECSTATE rtnetlink
> message.
This seems sub-optimal. My understanding is that this information is of
importance to the user space process that takes care of the ESMC
protocol. It would probably want to receive a notification when the
state of the DPLL/EEC changes as opposed to polling the kernel or poking
into its log.
So I think that whatever netlink-based interface we agree on to
represent the EEC (devlink or something else), should have the ability
to send a notification when the state changes.
next prev parent reply other threads:[~2021-09-21 13:26 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 15:14 [RFC v4 net-next 0/2] Add RTNL interface for SyncE Maciej Machnikowski
2021-09-03 15:14 ` [PATCH net-next 1/2] rtnetlink: Add new RTM_GETEECSTATE message to get SyncE status Maciej Machnikowski
2021-09-03 16:18 ` Stephen Hemminger
2021-09-03 22:20 ` Machnikowski, Maciej
2021-09-03 22:14 ` Jakub Kicinski
2021-09-06 18:30 ` Machnikowski, Maciej
2021-09-06 18:39 ` Jakub Kicinski
2021-09-06 19:01 ` Machnikowski, Maciej
2021-09-07 1:01 ` Jakub Kicinski
2021-09-07 8:50 ` Machnikowski, Maciej
2021-09-07 14:55 ` Jakub Kicinski
2021-09-07 15:47 ` Machnikowski, Maciej
2021-09-07 19:47 ` Jakub Kicinski
2021-09-08 8:03 ` Machnikowski, Maciej
2021-09-08 16:21 ` Jakub Kicinski
2021-09-08 17:30 ` Machnikowski, Maciej
2021-09-08 19:34 ` Andrew Lunn
2021-09-08 20:27 ` Machnikowski, Maciej
2021-09-08 22:20 ` Jakub Kicinski
2021-09-08 22:59 ` Andrew Lunn
2021-09-09 2:09 ` Richard Cochran
2021-09-09 8:18 ` Machnikowski, Maciej
2021-09-10 14:14 ` Richard Cochran
2021-09-08 22:18 ` Jakub Kicinski
2021-09-08 23:14 ` Andrew Lunn
2021-09-08 23:58 ` Jakub Kicinski
2021-09-09 8:26 ` Machnikowski, Maciej
2021-09-09 9:24 ` Machnikowski, Maciej
2021-09-09 10:15 ` David Miller
2021-09-09 8:11 ` Machnikowski, Maciej
2021-09-13 8:50 ` Ido Schimmel
2021-09-21 13:36 ` Ido Schimmel
2021-09-21 13:15 ` Ido Schimmel
2021-09-21 13:37 ` Machnikowski, Maciej
2021-09-21 14:58 ` Ido Schimmel
2021-09-21 21:14 ` Jakub Kicinski
2021-09-22 6:22 ` Ido Schimmel
2021-09-03 15:14 ` [PATCH net-next 2/2] ice: add support for reading SyncE DPLL state Maciej Machnikowski
2021-09-03 22:06 ` Jakub Kicinski
2021-09-21 13:25 ` Ido Schimmel [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-31 11:52 [PATCH net-next 0/2] Add RTNL interface for SyncE EEC state Maciej Machnikowski
2021-08-31 11:52 ` [PATCH net-next 2/2] ice: add support for reading SyncE DPLL state Maciej Machnikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUndYq8EcpyPnPud@shredder \
--to=idosch@idosch.org \
--cc=abyagowi@fb.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.machnikowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).