From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C668C433F5 for ; Tue, 21 Sep 2021 13:26:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0271961090 for ; Tue, 21 Sep 2021 13:26:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233053AbhIUN1a (ORCPT ); Tue, 21 Sep 2021 09:27:30 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:42203 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232906AbhIUN12 (ORCPT ); Tue, 21 Sep 2021 09:27:28 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 035A53200987; Tue, 21 Sep 2021 09:25:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 21 Sep 2021 09:26:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=FlxnQ1 G0tyJvkWQzOxKMOHkauuw5F5XxO64w6ivhM9I=; b=Akj2woKoe0MjMfRpR4lg+B akSbxXhneKhRxa8mQcO3Sql5UzLBN1dFldjShd7Kae0Jt8k1JPcW1YDBDzGybApq uSslHf7SumXCmVF7OMLWxoDCUIKXkFJ9ySIIAVdazEtv2JvaOwV+A/UcTUmhlauA vxbCNmxRIAxbWs9KVBlzjF1N5F7snzM9o/qRZxTSRdTkdfDCx0U7nJYsB6BYTCh2 lVO63+Tms49VvRI79biLcZ+k9uvDxMUZ9gWd1w2prHzbVKAOWIh0PSpoEC7NByjm 7RyKT4jg3Z/8K4jwU5r6/jJ21jw7W22bAksRa2OC9W1PNynSilM1g1VsavbxImiQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeigedgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedtffekkeefudffveegueejffejhfetgfeuuefgvedtieehudeuueekhfduheel teenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiug hoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Sep 2021 09:25:57 -0400 (EDT) Date: Tue, 21 Sep 2021 16:25:54 +0300 From: Ido Schimmel To: Maciej Machnikowski Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, richardcochran@gmail.com, abyagowi@fb.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next 2/2] ice: add support for reading SyncE DPLL state Message-ID: References: <20210903151436.529478-1-maciej.machnikowski@intel.com> <20210903151436.529478-3-maciej.machnikowski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210903151436.529478-3-maciej.machnikowski@intel.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 03, 2021 at 05:14:36PM +0200, Maciej Machnikowski wrote: > Implement SyncE DPLL monitoring for E810-T devices. > Poll loop will periodically check the state of the DPLL and cache it > in the pf structure. State changes will be logged in the system log. > > Cached state can be read using the RTM_GETEECSTATE rtnetlink > message. This seems sub-optimal. My understanding is that this information is of importance to the user space process that takes care of the ESMC protocol. It would probably want to receive a notification when the state of the DPLL/EEC changes as opposed to polling the kernel or poking into its log. So I think that whatever netlink-based interface we agree on to represent the EEC (devlink or something else), should have the ability to send a notification when the state changes.