From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-media@vger.kernel.org,
netdev@vger.kernel.org,
Brendan Higgins <brendanhiggins@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Thomas Graf <tgraf@suug.ch>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 3/4] lib/rhashtable: Replace kernel.h with the necessary inclusions
Date: Thu, 7 Oct 2021 14:44:41 +0300 [thread overview]
Message-ID: <YV7dqcCbxaeBcELY@smile.fi.intel.com> (raw)
In-Reply-To: <20211007112328.GA19281@gondor.apana.org.au>
On Thu, Oct 07, 2021 at 07:23:28PM +0800, Herbert Xu wrote:
> On Thu, Oct 07, 2021 at 12:51:28PM +0300, Andy Shevchenko wrote:
> > When kernel.h is used in the headers it adds a lot into dependency hell,
> > especially when there are circular dependencies are involved.
> > Replace kernel.h inclusion with the list of what is really being used.
> Nack. I can see the benefits of splitting things out of kernel.h
> but there is no reason to add crap to end users like rhashtable.c.
Crap is in the kernel.h. Could you elaborate how making a proper list
of the inclusions is a crap?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-10-07 11:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 9:51 [PATCH v2 0/4] kernel.h further split Andy Shevchenko
2021-10-07 9:51 ` [PATCH v2 1/4] kernel.h: Drop unneeded <linux/kernel.h> inclusion from other headers Andy Shevchenko
2021-10-07 9:51 ` [PATCH v2 2/4] kernel.h: Split out container_of() and typeof_member() macros Andy Shevchenko
2021-10-07 10:37 ` Greg Kroah-Hartman
2021-10-07 10:38 ` Greg Kroah-Hartman
2021-10-07 9:51 ` [PATCH v2 3/4] lib/rhashtable: Replace kernel.h with the necessary inclusions Andy Shevchenko
2021-10-07 11:23 ` Herbert Xu
2021-10-07 11:44 ` Andy Shevchenko [this message]
2021-10-08 2:18 ` Herbert Xu
2021-10-07 9:51 ` [PATCH v2 4/4] kunit: " Andy Shevchenko
2021-10-07 10:33 ` [PATCH v2 0/4] kernel.h further split Greg Kroah-Hartman
2021-10-07 11:51 ` Andy Shevchenko
2021-10-07 13:59 ` Greg Kroah-Hartman
2021-10-07 14:47 ` Andy Shevchenko
2021-10-07 15:07 ` Greg Kroah-Hartman
2021-10-08 9:37 ` Thorsten Leemhuis
2021-10-13 10:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV7dqcCbxaeBcELY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=brendanhiggins@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=kunit-dev@googlegroups.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tgraf@suug.ch \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).