netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	vladimir.oltean@nxp.com, michael@walle.cc
Subject: Re: [PATCH net-next 3/3] ethernet: use platform_get_ethdev_address()
Date: Thu, 7 Oct 2021 16:21:45 +0200	[thread overview]
Message-ID: <YV8CedxWOaC22Gkt@lunn.ch> (raw)
In-Reply-To: <20211007132511.3462291-4-kuba@kernel.org>

On Thu, Oct 07, 2021 at 06:25:11AM -0700, Jakub Kicinski wrote:
> Use the new platform_get_ethdev_address() helper for the cases
> where dev->dev_addr is passed in directly as the destination.
> 
>   @@
>   expression dev, net;
>   @@
>   - eth_platform_get_mac_address(dev, net->dev_addr)
>   + platform_get_ethdev_address(dev, net)
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

      reply	other threads:[~2021-10-07 14:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 13:25 [PATCH net-next 0/3] net: add a helpers for loading netdev->dev_addr from platform Jakub Kicinski
2021-10-07 13:25 ` [PATCH net-next 1/3] ethernet: un-export nvmem_get_mac_address() Jakub Kicinski
2021-10-07 14:08   ` Andrew Lunn
2021-10-07 13:25 ` [PATCH net-next 2/3] eth: platform: add a helper for loading netdev->dev_addr Jakub Kicinski
2021-10-07 13:42   ` Michael Walle
2021-10-07 13:57     ` Jakub Kicinski
2021-10-07 14:10       ` Andrew Lunn
2021-10-07 14:21         ` Jakub Kicinski
2021-10-07 13:25 ` [PATCH net-next 3/3] ethernet: use platform_get_ethdev_address() Jakub Kicinski
2021-10-07 14:21   ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YV8CedxWOaC22Gkt@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=michael@walle.cc \
    --cc=netdev@vger.kernel.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).