From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0650C433EF for ; Thu, 30 Sep 2021 15:13:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A834661882 for ; Thu, 30 Sep 2021 15:13:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245086AbhI3PP2 (ORCPT ); Thu, 30 Sep 2021 11:15:28 -0400 Received: from mail.netfilter.org ([217.70.188.207]:37588 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244780AbhI3PP0 (ORCPT ); Thu, 30 Sep 2021 11:15:26 -0400 Received: from netfilter.org (unknown [37.29.219.236]) by mail.netfilter.org (Postfix) with ESMTPSA id D8F2F63ED0; Thu, 30 Sep 2021 17:12:15 +0200 (CEST) Date: Thu, 30 Sep 2021 17:13:37 +0200 From: Pablo Neira Ayuso To: Jakub Kicinski Cc: Daniel Borkmann , netfilter-devel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, lukas@wunner.de, kadlec@netfilter.org, fw@strlen.de, ast@kernel.org, edumazet@google.com, tgraf@suug.ch, nevola@gmail.com, john.fastabend@gmail.com, willemb@google.com Subject: Re: [PATCH nf-next v5 0/6] Netfilter egress hook Message-ID: References: <20210928095538.114207-1-pablo@netfilter.org> <3973254b-9afb-72d5-7bf1-59edfcf39a58@iogearbox.net> <20210930072835.791085f3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210930072835.791085f3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Sep 30, 2021 at 07:28:35AM -0700, Jakub Kicinski wrote: > On Thu, 30 Sep 2021 11:21:42 +0200 Pablo Neira Ayuso wrote: [...] > The lifetime of this information is constrained, can't it be a percpu > flag, like xmit_more? It's just one single bit in this case after all. > > Probably the sysctl for this new egress hook is the way to go as you > > suggest. > > Knobs is making users pay, let's do our best to avoid that. Could you elaborate? Thanks.