From: Andrew Lunn <andrew@lunn.ch>
To: Frieder Schrempf <frieder@fris.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Bjarni Jonasson <bjarni.jonasson@microchip.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Russell King <linux@armlinux.org.uk>,
Steen Hegelund <steen.hegelund@microchip.com>
Subject: Re: [PATCH 1/3] net: phy: mscc: Add possibilty to disable combined LED mode
Date: Fri, 1 Oct 2021 02:05:12 +0200 [thread overview]
Message-ID: <YVZQuIr2poOfWvcO@lunn.ch> (raw)
In-Reply-To: <20210930125747.2511954-1-frieder@fris.de>
On Thu, Sep 30, 2021 at 02:57:43PM +0200, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> By default the LED modes offer to combine two indicators like speed/link
> and activity in one LED. In order to use a LED only for the first of the
> two modes, the combined feature needs to be disabled.
>
> In order to do this we introduce a boolean devicetree property
> 'vsc8531,led-[N]-combine-disable' and wire it up to the matching
> bits in the LED behavior register.
Sorry, but no DT property. Each PHY has its own magic combination of
DT properties, nothing shared, nothing common. This does not scale.
Please look at the work being done to control PHY LEDs using the Linux
LED infrastructure. That should give us one uniform interface for all
PHY LEDs.
Andrew
next prev parent reply other threads:[~2021-10-01 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 12:57 [PATCH 1/3] net: phy: mscc: Add possibilty to disable combined LED mode Frieder Schrempf
2021-09-30 12:57 ` [PATCH 2/3] dt-bindings: net: phy: mscc: vsc8531: Add LED mode combine disable property Frieder Schrempf
2021-09-30 13:00 ` Frieder Schrempf
2021-10-01 0:05 ` Andrew Lunn [this message]
2021-10-01 9:20 ` [PATCH 1/3] net: phy: mscc: Add possibilty to disable combined LED mode Frieder Schrempf
2021-10-01 10:09 ` Marek Behún
2021-10-01 10:52 ` Frieder Schrempf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVZQuIr2poOfWvcO@lunn.ch \
--to=andrew@lunn.ch \
--cc=bjarni.jonasson@microchip.com \
--cc=davem@davemloft.net \
--cc=frieder.schrempf@kontron.de \
--cc=frieder@fris.de \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=steen.hegelund@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).