From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8BEDC433EF for ; Tue, 5 Oct 2021 11:00:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9185761139 for ; Tue, 5 Oct 2021 11:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234461AbhJELC3 (ORCPT ); Tue, 5 Oct 2021 07:02:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:42920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234376AbhJELCA (ORCPT ); Tue, 5 Oct 2021 07:02:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B933861139; Tue, 5 Oct 2021 11:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633431609; bh=v5FbJo5qrVUlbMZ3ddNVAYvu1mAUooqD0BmTMDlbz5k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xqck704VhP00sB3C9xaIHqb0opFwk5rr4RrKGlmHwh0EWL6l8+WCC8JySWIaECkaK rrH/af/kA/hxkUStFGDoonuPFVPhGxcqDdIckeuUqoGLj1SxV3fWaUqh9X+Ol9N1XV XlcgxMLyorZsPoqNQCFsEXvrsqkuqaEWK/GOsQg1ISFdEHJm41gEQrFHLdalOtmYcy btM7o8bjeJBQShzOXbKOQ9CjDt26gDSenSgKqkmjR9FlMLAB4brYy5sKD1dqTSdFUp cbc7Dm9AtOmLHl37TiL/Nrrf3B57aCprbV/nEtPBd/3MZrvPWM0sVNrWA8jrxTFEea 1F90rekWBDfJg== Date: Tue, 5 Oct 2021 14:00:05 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: Doug Ledford , Aharon Landau , "David S. Miller" , Dennis Dalessandro , Gal Pressman , Jakub Kicinski , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Maor Gottlieb , Mark Zhang , Mike Marciniszyn , Mustafa Ismail , Naresh Kumar PBS , Neta Ostrovsky , netdev@vger.kernel.org, Potnuri Bharat Teja , Saeed Mahameed , Selvin Xavier , Shiraz Saleem , Yishai Hadas , Zhu Yanjun Subject: Re: [PATCH rdma-next v2 13/13] RDMA/nldev: Add support to get status of all counters Message-ID: References: <20211004180714.GE2515663@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211004180714.GE2515663@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Oct 04, 2021 at 03:07:14PM -0300, Jason Gunthorpe wrote: > On Thu, Sep 30, 2021 at 11:02:29AM +0300, Leon Romanovsky wrote: > > +static int stat_get_doit_default_counter(struct sk_buff *skb, > > + struct nlmsghdr *nlh, > > + struct netlink_ext_ack *extack, > > + struct nlattr *tb[]) > > +{ > > + struct rdma_hw_stats *stats; > > + struct ib_device *device; > > + u32 index, port; > > + int ret; > > + > > + if (!tb[RDMA_NLDEV_ATTR_DEV_INDEX] || !tb[RDMA_NLDEV_ATTR_PORT_INDEX]) > > + return -EINVAL; > > + > > + index = nla_get_u32(tb[RDMA_NLDEV_ATTR_DEV_INDEX]); > > + device = ib_device_get_by_index(sock_net(skb->sk), index); > > + if (!device) > > + return -EINVAL; > > + > > + port = nla_get_u32(tb[RDMA_NLDEV_ATTR_PORT_INDEX]); > > + if (!rdma_is_port_valid(device, port)) { > > + ret = -EINVAL; > > + goto end; > > + } > > + > > + stats = ib_get_hw_stats_port(device, port); > > + if (!stats) { > > + ret = -EINVAL; > > + goto end; > > + } > > + > > + if (tb[RDMA_NLDEV_ATTR_STAT_HWCOUNTER_DYNAMIC]) > > + ret = stat_get_doit_stats_list(skb, nlh, extack, tb, > > + device, port, stats); > > + else > > + ret = stat_get_doit_stats_values(skb, nlh, extack, tb, device, > > + port, stats); > > And this is still here - 'gets' do not act differently depending on > inputs.. This patch shouldn't be sent at all. Sorry for the noise. Thanks > > Jason