From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA477C433EF for ; Tue, 19 Oct 2021 06:50:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC5496115B for ; Tue, 19 Oct 2021 06:50:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229846AbhJSGxC (ORCPT ); Tue, 19 Oct 2021 02:53:02 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:46129 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229649AbhJSGxB (ORCPT ); Tue, 19 Oct 2021 02:53:01 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id E917A3200F6F; Tue, 19 Oct 2021 02:50:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 19 Oct 2021 02:50:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=480Xut i6WMD7oXbzl7SOf79XKVvGXiS+iqAnhPGVbxw=; b=ViC41NzXT3m4OL0/mMfsDM lF6Bthhuh3QBTIsiftzoZsp5KH6Vc+VQivtHD5Ne/PhzMFO2GQop+Aw/llIvco01 R47K9fZePzmLpklRY2CFOSXDpafAv+nqZWeth5qpXfc/vreL/2bX6RhGVvc0uSfD nPa3e/Vb1q3B+TsU5PIf5ytahbGyQazGh7DZr8Hf/u/a13Qm18YFL6T6AjiJMaBd m5lu1Kd4ijKPyKBotcNTEns8X7TyiJqRLmroYdRGqmVesEniWM726xDTasrGd/oi JvQ7X+udqJVTrsDmhLV0p5DBUbavyEs6q8q3LsFpHjvyrlnMKzYVg4laaWhjGdnw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvuddguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnheptdffkeekfeduffevgeeujeffjefhtefgueeugfevtdeiheduueeukefhudeh leetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Oct 2021 02:50:47 -0400 (EDT) Date: Tue, 19 Oct 2021 09:50:44 +0300 From: Ido Schimmel To: Eric Dumazet Cc: "David S . Miller" , Jakub Kicinski , netdev , Eric Dumazet , "Ahmed S . Darwish" , Sebastian Andrzej Siewior Subject: Re: [PATCH net-next 1/2] net: sched: fix logic error in qdisc_run_begin() Message-ID: References: <20211019003402.2110017-1-eric.dumazet@gmail.com> <20211019003402.2110017-2-eric.dumazet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211019003402.2110017-2-eric.dumazet@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Oct 18, 2021 at 05:34:01PM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > For non TCQ_F_NOLOCK qdisc, qdisc_run_begin() tries to set > __QDISC_STATE_RUNNING and should return true if the bit was not set. > > test_and_set_bit() returns old bit value, therefore we need to invert. > > Fixes: 29cbcd858283 ("net: sched: Remove Qdisc::running sequence counter") > Signed-off-by: Eric Dumazet > Cc: Ahmed S. Darwish > Cc: Sebastian Andrzej Siewior Tested-by: Ido Schimmel Thanks!