From: Leon Romanovsky <leon@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: thomas.lendacky@amd.com, davem@davemloft.net, kuba@kernel.org,
rmody@marvell.com, skalluru@marvell.com,
GR-Linux-NIC-Dev@marvell.com, dchickles@marvell.com,
sburla@marvell.com, fmanlunas@marvell.com,
ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com,
somnath.kotur@broadcom.com, sgoutham@marvell.com,
lcherian@marvell.com, gakula@marvell.com, jerinj@marvell.com,
hkelam@marvell.com, sbhatta@marvell.com, tariqt@nvidia.com,
saeedm@nvidia.com, aelior@marvell.com,
GR-everest-linux-l2@marvell.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ethernet: Remove redundant 'flush_workqueue()' calls
Date: Sun, 10 Oct 2021 13:03:39 +0300 [thread overview]
Message-ID: <YWK6e2+hDGS9xblC@unreal> (raw)
In-Reply-To: <3dadac919f6f4a991953965ddbb975f2586e6ecf.1633848953.git.christophe.jaillet@wanadoo.fr>
On Sun, Oct 10, 2021 at 09:01:32AM +0200, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 --
> drivers/net/ethernet/brocade/bna/bnad.c | 1 -
> drivers/net/ethernet/cavium/liquidio/lio_core.c | 1 -
> drivers/net/ethernet/emulex/benet/be_main.c | 1 -
> drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 1 -
> drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 --
> drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c | 1 -
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c | 1 -
> drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 --
> drivers/net/ethernet/mellanox/mlx4/en_main.c | 1 -
> drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 1 -
> drivers/net/ethernet/qlogic/qed/qed_sriov.c | 1 -
> 12 files changed, 15 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com> #mlx*
next prev parent reply other threads:[~2021-10-10 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 7:01 [PATCH] ethernet: Remove redundant 'flush_workqueue()' calls Christophe JAILLET
2021-10-10 10:03 ` Leon Romanovsky [this message]
2021-10-10 10:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWK6e2+hDGS9xblC@unreal \
--to=leon@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=ajit.khaparde@broadcom.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=fmanlunas@marvell.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmody@marvell.com \
--cc=saeedm@nvidia.com \
--cc=sbhatta@marvell.com \
--cc=sburla@marvell.com \
--cc=sgoutham@marvell.com \
--cc=skalluru@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=tariqt@nvidia.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).