* [PATCH net-next] ionic: no devlink_unregister if not registered
@ 2021-10-12 23:15 Shannon Nelson
2021-10-13 0:33 ` Leon Romanovsky
2021-10-13 2:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Shannon Nelson @ 2021-10-12 23:15 UTC (permalink / raw)
To: davem, netdev, kuba; +Cc: drivers, Shannon Nelson, Leon Romanovsky
Don't try to unregister the devlink if it hasn't been registered
yet. This bit of error cleanup code got missed in the recent
devlink registration changes.
Fixes: 7911c8bd546f ("ionic: Move devlink registration to be last devlink command")
Cc: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Shannon Nelson <snelson@pensando.io>
---
drivers/net/ethernet/pensando/ionic/ionic_devlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c
index 2267da95640b..4297ed9024c0 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c
@@ -87,7 +87,6 @@ int ionic_devlink_register(struct ionic *ionic)
err = devlink_port_register(dl, &ionic->dl_port, 0);
if (err) {
dev_err(ionic->dev, "devlink_port_register failed: %d\n", err);
- devlink_unregister(dl);
return err;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ionic: no devlink_unregister if not registered
2021-10-12 23:15 [PATCH net-next] ionic: no devlink_unregister if not registered Shannon Nelson
@ 2021-10-13 0:33 ` Leon Romanovsky
2021-10-13 2:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2021-10-13 0:33 UTC (permalink / raw)
To: Shannon Nelson; +Cc: davem, netdev, kuba, drivers
On Tue, Oct 12, 2021 at 04:15:20PM -0700, Shannon Nelson wrote:
> Don't try to unregister the devlink if it hasn't been registered
> yet. This bit of error cleanup code got missed in the recent
> devlink registration changes.
>
> Fixes: 7911c8bd546f ("ionic: Move devlink registration to be last devlink command")
> Cc: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Shannon Nelson <snelson@pensando.io>
> ---
> drivers/net/ethernet/pensando/ionic/ionic_devlink.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ionic: no devlink_unregister if not registered
2021-10-12 23:15 [PATCH net-next] ionic: no devlink_unregister if not registered Shannon Nelson
2021-10-13 0:33 ` Leon Romanovsky
@ 2021-10-13 2:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-13 2:40 UTC (permalink / raw)
To: Shannon Nelson; +Cc: davem, netdev, kuba, drivers, leonro
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 12 Oct 2021 16:15:20 -0700 you wrote:
> Don't try to unregister the devlink if it hasn't been registered
> yet. This bit of error cleanup code got missed in the recent
> devlink registration changes.
>
> Fixes: 7911c8bd546f ("ionic: Move devlink registration to be last devlink command")
> Cc: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Shannon Nelson <snelson@pensando.io>
>
> [...]
Here is the summary with links:
- [net-next] ionic: no devlink_unregister if not registered
https://git.kernel.org/netdev/net-next/c/d1f24712a86a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-13 2:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-12 23:15 [PATCH net-next] ionic: no devlink_unregister if not registered Shannon Nelson
2021-10-13 0:33 ` Leon Romanovsky
2021-10-13 2:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).