From: Hangbin Liu <liuhangbin@gmail.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@nvidia.com,
bridge@lists.linux-foundation.org, kuba@kernel.org,
davem@davemloft.net
Subject: Re: [PATCH net-next v4 10/15] net: bridge: mcast: support for IGMPv3/MLDv2 ALLOW_NEW_SOURCES report
Date: Fri, 15 Oct 2021 14:36:59 +0800 [thread overview]
Message-ID: <YWkhi7iABEKygKaL@Laptop-X1> (raw)
In-Reply-To: <YWjsyk/Dzg2/zVbw@Laptop-X1>
On Fri, Oct 15, 2021 at 10:52:00AM +0800, Hangbin Liu wrote:
> > - mod_timer(&p->timer, now + br->multicast_membership_interval);
> > + if (igmpv2_mldv1)
> > + mod_timer(&p->timer, now + br->multicast_membership_interval);
>
> Hi Nikolay,
>
> Our engineer found that the multicast_membership_interval will not work with
> IGMPv3. Is it intend as you said "IGMPv3/MLDv2 handling is not yet
> implemented" ?
Ah, I saw in br_multicast_group_expired() it wait for mp->ports be freed
before delete the mdb entry.
And in br_multicast_port_group_expired() it wait for src entry freed first.
But when mod group src timer, we use
__grp_src_mod_timer(ent, now + br_multicast_gmi(brmctx));
instead of user configured multicast_membership_interval. I think we should
fix it. WDYT?
Thanks
Hangbin
next prev parent reply other threads:[~2021-10-15 6:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 9:56 [PATCH net-next v4 00/15] net: bridge: mcast: initial IGMPv3/MLDv2 support (part 1) Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 01/15] net: bridge: mdb: arrange internal structs so fast-path fields are close Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 02/15] net: bridge: mcast: factor out port group del Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 03/15] net: bridge: mcast: add support for group source list Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 04/15] net: bridge: mcast: add support for src list and filter mode dumping Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 05/15] net: bridge: mcast: add support for group-and-source specific queries Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 06/15] net: bridge: mcast: add support for group query retransmit Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 07/15] net: bridge: mdb: push notifications in __br_mdb_add/del Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 08/15] net: bridge: mdb: use mdb and port entries in notifications Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 09/15] net: bridge: mcast: delete expired port groups without srcs Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 10/15] net: bridge: mcast: support for IGMPv3/MLDv2 ALLOW_NEW_SOURCES report Nikolay Aleksandrov
2021-10-15 2:51 ` Hangbin Liu
2021-10-15 6:36 ` Hangbin Liu [this message]
2021-10-15 8:57 ` Nikolay Aleksandrov
2021-10-15 9:05 ` [PATCH net] net: bridge: mcast: use multicast_membership_interval for IGMPv3 Nikolay Aleksandrov
2021-10-16 14:10 ` patchwork-bot+netdevbpf
2020-09-07 9:56 ` [PATCH net-next v4 11/15] net: bridge: mcast: support for IGMPV3/MLDv2 MODE_IS_INCLUDE/EXCLUDE report Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 12/15] net: bridge: mcast: support for IGMPV3/MLDv2 CHANGE_TO_INCLUDE/EXCLUDE report Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 13/15] net: bridge: mcast: support for IGMPV3/MLDv2 BLOCK_OLD_SOURCES report Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 14/15] net: bridge: mcast: improve IGMPv3/MLDv2 query processing Nikolay Aleksandrov
2020-09-07 9:56 ` [PATCH net-next v4 15/15] net: bridge: mcast: destroy all entries via gc Nikolay Aleksandrov
2020-09-07 20:27 ` [PATCH net-next v4 00/15] net: bridge: mcast: initial IGMPv3/MLDv2 support (part 1) Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWkhi7iABEKygKaL@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox