[PATCH net-next] netdevsim: remove max_vfs dentry

[PATCH net-next] netdevsim: remove max_vfs dentry

[Jakub Kicinski]

Commit d395381909a3 ("netdevsim: Add max_vfs to bus_dev")
added this file and saved the dentry for no apparent reason.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 drivers/net/netdevsim/dev.c       | 8 +++-----
 drivers/net/netdevsim/netdevsim.h | 1 -
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
index 3d28ca14acdd..b82089cd71d1 100644
--- a/drivers/net/netdevsim/dev.c
+++ b/drivers/net/netdevsim/dev.c
@@ -265,11 +265,9 @@ static int nsim_dev_debugfs_init(struct nsim_dev *nsim_dev)
 	debugfs_create_bool("fail_trap_policer_counter_get", 0600,
 			    nsim_dev->ddir,
 			    &nsim_dev->fail_trap_policer_counter_get);
-	nsim_dev->max_vfs = debugfs_create_file("max_vfs",
-						0600,
-						nsim_dev->ddir,
-						nsim_dev->nsim_bus_dev,
-						&nsim_dev_max_vfs_fops);
+	debugfs_create_file("max_vfs", 0600, nsim_dev->ddir,
+			    nsim_dev->nsim_bus_dev, &nsim_dev_max_vfs_fops);
+
 	nsim_dev->nodes_ddir = debugfs_create_dir("rate_nodes", nsim_dev->ddir);
 	if (IS_ERR(nsim_dev->nodes_ddir)) {
 		err = PTR_ERR(nsim_dev->nodes_ddir);
diff --git a/drivers/net/netdevsim/netdevsim.h b/drivers/net/netdevsim/netdevsim.h
index f8df2bfdb777..e58851aff9fa 100644
--- a/drivers/net/netdevsim/netdevsim.h
+++ b/drivers/net/netdevsim/netdevsim.h
@@ -224,7 +224,6 @@ struct nsim_dev {
 	struct dentry *ddir;
 	struct dentry *ports_ddir;
 	struct dentry *take_snapshot;
-	struct dentry *max_vfs;
 	struct dentry *nodes_ddir;
 	struct bpf_offload_dev *bpf_dev;
 	bool bpf_bind_accept;
-- 
2.31.1

Re: [PATCH net-next] netdevsim: remove max_vfs dentry

[Leon Romanovsky]

On Thu, Oct 28, 2021 at 02:17:53PM -0700, Jakub Kicinski wrote:
> Commit d395381909a3 ("netdevsim: Add max_vfs to bus_dev")
> added this file and saved the dentry for no apparent reason.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  drivers/net/netdevsim/dev.c       | 8 +++-----
>  drivers/net/netdevsim/netdevsim.h | 1 -
>  2 files changed, 3 insertions(+), 6 deletions(-)

I think that "debugfs_create_file("ipsec", 0400, ..." can be cleaned
too. It is connected to ddir, which is removed recursively.

Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

Thanks