From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Luo Jie <luoj@codeaurora.org>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH v6 01/14] net: phy: at803x: replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS
Date: Sat, 23 Oct 2021 10:57:07 +0100 [thread overview]
Message-ID: <YXPcczBI2Keg8i8s@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211023095453.22615-2-luoj@codeaurora.org>
On Sat, Oct 23, 2021 at 05:54:40PM +0800, Luo Jie wrote:
> Replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS defined in mdio.h.
>
> Signed-off-by: Luo Jie <luoj@codeaurora.org>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
This is still wrong. Andrew reviewed it, and then I did. I gave you a
reviewed tag as well.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-10-23 9:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-23 9:54 [PATCH v6 0/14] net: phy: Add qca8081 ethernet phy driver Luo Jie
2021-10-23 9:54 ` [PATCH v6 01/14] net: phy: at803x: replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS Luo Jie
2021-10-23 9:57 ` Russell King (Oracle) [this message]
2021-10-23 10:08 ` Jie Luo
2021-10-23 9:54 ` [PATCH v6 02/14] net: phy: at803x: use phy_modify() Luo Jie
2021-10-23 9:54 ` [PATCH v6 03/14] net: phy: at803x: improve the WOL feature Luo Jie
2021-10-23 9:54 ` [PATCH v6 04/14] net: phy: at803x: use GENMASK() for speed status Luo Jie
2021-10-23 9:54 ` [PATCH v6 05/14] net: phy: add qca8081 ethernet phy driver Luo Jie
2021-10-23 9:54 ` [PATCH v6 06/14] net: phy: add qca8081 read_status Luo Jie
2021-10-23 9:54 ` [PATCH v6 07/14] net: phy: add qca8081 get_features Luo Jie
2021-10-23 9:54 ` [PATCH v6 08/14] net: phy: add qca8081 config_aneg Luo Jie
2021-10-23 9:54 ` [PATCH v6 09/14] net: phy: add constants for fast retrain related register Luo Jie
2021-10-23 9:54 ` [PATCH v6 10/14] net: phy: add genphy_c45_fast_retrain Luo Jie
2021-10-23 9:54 ` [PATCH v6 11/14] net: phy: add qca8081 config_init Luo Jie
2021-10-23 9:54 ` [PATCH v6 12/14] net: phy: add qca8081 soft_reset and enable master/slave seed Luo Jie
2021-10-23 9:54 ` [PATCH v6 13/14] net: phy: adjust qca8081 master/slave seed value if link down Luo Jie
2021-10-23 9:54 ` [PATCH v6 14/14] net: phy: add qca8081 cdt feature Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXPcczBI2Keg8i8s@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luoj@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).