From: Andrew Lunn <andrew@lunn.ch>
To: Sean Anderson <sean.anderson@seco.com>
Cc: netdev@vger.kernel.org, Russell King <rmk+kernel@armlinux.org.uk>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
linux-rdma@vger.kernel.org
Subject: Re: [net-next PATCH] net: convert users of bitmap_foo() to linkmode_foo()
Date: Sun, 24 Oct 2021 20:50:45 +0200 [thread overview]
Message-ID: <YXWrBZJGof6uIQnq@lunn.ch> (raw)
In-Reply-To: <20211022224104.3541725-1-sean.anderson@seco.com>
On Fri, Oct 22, 2021 at 06:41:04PM -0400, Sean Anderson wrote:
> This converts instances of
> bitmap_foo(args..., __ETHTOOL_LINK_MODE_MASK_NBITS)
> to
> linkmode_foo(args...)
It does touch a lot of files, but it does help keep the API uniform.
> I manually fixed up some lines to prevent them from being excessively
> long. Otherwise, this change was generated with the following semantic
> patch:
How many did you fix?
> Because this touches so many files in the net tree, you may want to
> generate a new diff using the semantic patch above when you apply this.
If it still applies cleanly, i would just apply it. Otherwise maybe
Jakub could recreate it?
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-10-24 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 22:41 [net-next PATCH] net: convert users of bitmap_foo() to linkmode_foo() Sean Anderson
2021-10-24 18:50 ` Andrew Lunn [this message]
2021-10-25 15:06 ` Sean Anderson
2021-10-25 19:20 ` Jakub Kicinski
2021-10-25 19:26 ` Sean Anderson
2021-10-25 19:36 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXWrBZJGof6uIQnq@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sean.anderson@seco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox