From: Leon Romanovsky <leonro@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <saeedm@nvidia.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5: remove the recent devlink params
Date: Tue, 26 Oct 2021 19:45:10 +0300 [thread overview]
Message-ID: <YXgwlsyGtK8qZfHj@unreal> (raw)
In-Reply-To: <20211026152939.3125950-1-kuba@kernel.org>
On Tue, Oct 26, 2021 at 08:29:39AM -0700, Jakub Kicinski wrote:
> revert commit 46ae40b94d88 ("net/mlx5: Let user configure io_eq_size param")
> revert commit a6cb08daa3b4 ("net/mlx5: Let user configure event_eq_size param")
> revert commit 554604061979 ("net/mlx5: Let user configure max_macs param")
>
> The EQE parameters are applicable to more drivers, they should
> be configured via standard API, probably ethtool. Example of
> another driver needing something similar:
>
> https://lore.kernel.org/all/1633454136-14679-3-git-send-email-sbhatta@marvell.com/
>
> The last param for "max_macs" is probably fine but the documentation
> is severely lacking. The meaning and implications for changing the
> param need to be stated.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> LocalWords: EQE param
Your emacs config sneaked out.
Thanks
next prev parent reply other threads:[~2021-10-26 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 15:29 [PATCH net-next] net/mlx5: remove the recent devlink params Jakub Kicinski
2021-10-26 15:53 ` Parav Pandit
2021-10-26 16:47 ` Jakub Kicinski
2021-10-26 19:11 ` Saeed Mahameed
2021-10-26 16:45 ` Leon Romanovsky [this message]
2021-10-26 16:47 ` Jakub Kicinski
2021-10-26 17:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXgwlsyGtK8qZfHj@unreal \
--to=leonro@nvidia.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox