From: Ido Schimmel <idosch@idosch.org>
To: Maciej Machnikowski <maciej.machnikowski@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
richardcochran@gmail.com, abyagowi@fb.com,
anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org,
linux-kselftest@vger.kernel.org, mkubecek@suse.cz,
saeed@kernel.org, michael.chan@broadcom.com
Subject: Re: [RFC v5 net-next 2/5] rtnetlink: Add new RTM_GETEECSTATE message to get SyncE status
Date: Wed, 27 Oct 2021 10:10:18 +0300 [thread overview]
Message-ID: <YXj7WkEb0PagWfSw@shredder> (raw)
In-Reply-To: <20211026173146.1031412-3-maciej.machnikowski@intel.com>
On Tue, Oct 26, 2021 at 07:31:43PM +0200, Maciej Machnikowski wrote:
> +/* SyncE section */
> +
> +enum if_eec_state {
> + IF_EEC_STATE_INVALID = 0,
> + IF_EEC_STATE_FREERUN,
> + IF_EEC_STATE_LOCKED,
> + IF_EEC_STATE_LOCKED_HO_ACQ,
Is this referring to "Locked mode, acquiring holdover: This is a
temporary mode, when coming from free-run, to acquire holdover memory."
?
It seems ice isn't using it, so maybe drop it? Can be added later in
case we have a driver that can report it
There is also "Locked mode, holdover acquired: This is a steady state
mode, entered when holdover memory is acquired." But I assume that's
"IF_EEC_STATE_LOCKED"
> + IF_EEC_STATE_HOLDOVER,
> +};
next prev parent reply other threads:[~2021-10-27 7:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 17:31 [RFC v5 net-next 0/5] Add RTNL interface for SyncE Maciej Machnikowski
2021-10-26 17:31 ` [RFC v5 net-next 1/5] ice: add support detecting features based on netlist Maciej Machnikowski
2021-10-26 17:31 ` [RFC v5 net-next 2/5] rtnetlink: Add new RTM_GETEECSTATE message to get SyncE status Maciej Machnikowski
2021-10-27 7:10 ` Ido Schimmel [this message]
2021-10-27 13:16 ` Machnikowski, Maciej
2021-10-27 15:10 ` Ido Schimmel
2021-10-28 6:34 ` Machnikowski, Maciej
2021-10-26 17:31 ` [RFC v5 net-next 3/5] ice: add support for reading SyncE DPLL state Maciej Machnikowski
2021-10-26 17:31 ` [RFC v5 net-next 4/5] rtnetlink: Add support for SyncE recovered clock configuration Maciej Machnikowski
2021-10-26 21:32 ` Jakub Kicinski
2021-10-27 13:29 ` Machnikowski, Maciej
2021-10-27 14:40 ` Jakub Kicinski
2021-10-26 17:31 ` [RFC v5 net-next 5/5] ice: add support for SyncE recovered clocks Maciej Machnikowski
2021-10-27 6:50 ` [RFC v5 net-next 0/5] Add RTNL interface for SyncE Ido Schimmel
2021-10-27 13:21 ` Machnikowski, Maciej
2021-10-27 15:05 ` Ido Schimmel
2021-10-28 6:32 ` Machnikowski, Maciej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXj7WkEb0PagWfSw@shredder \
--to=idosch@idosch.org \
--cc=abyagowi@fb.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.machnikowski@intel.com \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=saeed@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).