From: Ido Schimmel <idosch@idosch.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next 8/8] net: switchdev: merge switchdev_handle_fdb_{add,del}_to_device
Date: Wed, 27 Oct 2021 11:46:08 +0300 [thread overview]
Message-ID: <YXkR0NCj1OyEwycZ@shredder> (raw)
In-Reply-To: <20211026142743.1298877-9-vladimir.oltean@nxp.com>
On Tue, Oct 26, 2021 at 05:27:43PM +0300, Vladimir Oltean wrote:
> To reduce code churn, the same patch makes multiple changes, since they
> all touch the same lines:
>
> 1. The implementations for these two are identical, just with different
> function pointers. Reduce duplications and name the function pointers
> "mod_cb" instead of "add_cb" and "del_cb". Pass the event as argument.
>
> 2. Drop the "const" attribute from "orig_dev". If the driver needs to
> check whether orig_dev belongs to itself and then
> call_switchdev_notifiers(orig_dev, SWITCHDEV_FDB_OFFLOADED), it
> can't, because call_switchdev_notifiers takes a non-const struct
> net_device *.
Regarding 2, I don't mind about the code change itself, but can you
expand on the motivation? Is this required for a subsequent patchset you
plan to submit?
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2021-10-27 8:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 14:27 [PATCH net-next 0/8] Bridge FDB refactoring Vladimir Oltean
2021-10-26 14:27 ` [PATCH net-next 1/8] net: bridge: remove fdb_notify forward declaration Vladimir Oltean
2021-10-27 7:45 ` Ido Schimmel
2021-10-27 8:29 ` Nikolay Aleksandrov
2021-10-26 14:27 ` [PATCH net-next 2/8] net: bridge: remove fdb_insert " Vladimir Oltean
2021-10-27 7:47 ` Ido Schimmel
2021-10-27 8:29 ` Nikolay Aleksandrov
2021-10-26 14:27 ` [PATCH net-next 3/8] net: bridge: rename fdb_insert to fdb_add_local Vladimir Oltean
2021-10-27 7:51 ` Ido Schimmel
2021-10-27 8:31 ` Nikolay Aleksandrov
2021-10-26 14:27 ` [PATCH net-next 4/8] net: bridge: rename br_fdb_insert to br_fdb_add_local Vladimir Oltean
2021-10-27 7:54 ` Ido Schimmel
2021-10-27 8:32 ` Nikolay Aleksandrov
2021-10-26 14:27 ` [PATCH net-next 5/8] net: bridge: reduce indentation level in fdb_create Vladimir Oltean
2021-10-27 8:05 ` Ido Schimmel
2021-10-27 8:32 ` Nikolay Aleksandrov
2021-10-26 14:27 ` [PATCH net-next 6/8] net: bridge: move br_fdb_replay inside br_switchdev.c Vladimir Oltean
2021-10-27 8:16 ` Ido Schimmel
2021-10-27 8:28 ` Nikolay Aleksandrov
2021-10-27 12:58 ` Vladimir Oltean
2021-10-27 13:04 ` Vladimir Oltean
2021-10-26 14:27 ` [PATCH net-next 7/8] net: bridge: create a common function for populating switchdev FDB entries Vladimir Oltean
2021-10-27 8:26 ` Ido Schimmel
2021-10-27 8:39 ` Nikolay Aleksandrov
2021-10-26 14:27 ` [PATCH net-next 8/8] net: switchdev: merge switchdev_handle_fdb_{add,del}_to_device Vladimir Oltean
2021-10-27 8:46 ` Ido Schimmel [this message]
2021-10-27 11:28 ` Vladimir Oltean
2021-10-27 14:40 ` [PATCH net-next 0/8] Bridge FDB refactoring patchwork-bot+netdevbpf
2021-10-27 14:44 ` Nikolay Aleksandrov
2021-10-27 14:46 ` Vladimir Oltean
2021-10-27 14:49 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXkR0NCj1OyEwycZ@shredder \
--to=idosch@idosch.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=roopa@nvidia.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).