From: Andrew Lunn <andrew@lunn.ch>
To: Yuiko.Oshino@microchip.com
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Nisar.Sayed@microchip.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next] net: phy: microchip_t1: add cable test support for lan87xx phy
Date: Wed, 27 Oct 2021 16:46:32 +0200 [thread overview]
Message-ID: <YXlmSByDhPo0ZwWb@lunn.ch> (raw)
In-Reply-To: <CH0PR11MB55619DF408C4EC0D729BC87F8E859@CH0PR11MB5561.namprd11.prod.outlook.com>
> >> + /* start cable diag */
> >> + /* check if part is alive - if not, return diagnostic error */
> >> + rc = access_ereg(phydev, PHYACC_ATTR_MODE_READ,
> >PHYACC_ATTR_BANK_SMI,
> >> + 0x00, 0);
> >> + if (rc < 0)
> >> + return rc;
> >> +
> >> + if (rc != 0x2100)
> >> + return -ENODEV;
> >
> >What does this actually mean? Would -EOPNOTSUPP be better?
>
> This register should return the value of 0x2100. So if the return value is different, then I assume there is no device.
If the device does not exist, can we have go this far? Would probe of
the PHY failed? Or are you talking about a device within a device? Is
cable test implemented using an optional component?
Andrew
next prev parent reply other threads:[~2021-10-27 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 18:36 [PATCH net-next] net: phy: microchip_t1: add cable test support for lan87xx phy Yuiko Oshino
2021-10-22 19:48 ` Andrew Lunn
2021-10-27 14:21 ` Yuiko.Oshino
2021-10-22 19:56 ` Andrew Lunn
2021-10-27 14:30 ` Yuiko.Oshino
2021-10-27 14:46 ` Andrew Lunn [this message]
2021-10-27 14:54 ` Yuiko.Oshino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXlmSByDhPo0ZwWb@lunn.ch \
--to=andrew@lunn.ch \
--cc=Nisar.Sayed@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Yuiko.Oshino@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).