From: Tony Lu <tonylu@linux.alibaba.com>
To: Karsten Graul <kgraul@linux.ibm.com>
Cc: davem@davemloft.net, kuba@kernel.org, ubraun@linux.ibm.com,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
linux-rdma@vger.kernel.org, jacob.qi@linux.alibaba.com,
xuanzhuo@linux.alibaba.com, guwen@linux.alibaba.com,
dust.li@linux.alibaba.com
Subject: Re: [PATCH net 2/4] net/smc: Fix smc_link->llc_testlink_time overflow
Date: Thu, 28 Oct 2021 14:52:09 +0800 [thread overview]
Message-ID: <YXpImWvmdMkK2wd0@TonyMac-Alibaba> (raw)
In-Reply-To: <c1d3d584-4a96-a34b-ed25-a376b17b36c7@linux.ibm.com>
On Wed, Oct 27, 2021 at 12:24:18PM +0200, Karsten Graul wrote:
> On 27/10/2021 10:52, Tony Lu wrote:
> > From: Tony Lu <tony.ly@linux.alibaba.com>
> >
> > The value of llc_testlink_time is set to the value stored in
> > net->ipv4.sysctl_tcp_keepalive_time when linkgroup init. The value of
> > sysctl_tcp_keepalive_time is already jiffies, so we don't need to
> > multiply by HZ, which would cause smc_link->llc_testlink_time overflow,
> > and test_link send flood.
>
> Thanks for fixing this, we will include your patch in our next submission
> to the netdev tree.
Thanks for your reply. There is a little mistake for my email address,
the wrong email address (tony.ly@linux.alibaba.com) should be corrected
to tonylu@linux.alibaba.com. I will send these two patches with the next
one in v2.
Cheers,
Tony Lu
next prev parent reply other threads:[~2021-10-28 6:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 8:52 [PATCH net 0/4] Fixes for SMC Tony Lu
2021-10-27 8:52 ` [PATCH net 1/4] Revert "net/smc: don't wait for send buffer space when data was already sent" Tony Lu
2021-10-27 10:21 ` Karsten Graul
2021-10-27 15:08 ` Jakub Kicinski
2021-10-27 15:38 ` Karsten Graul
2021-10-27 15:47 ` Jakub Kicinski
2021-10-28 6:48 ` Tony Lu
2021-10-28 11:57 ` Karsten Graul
2021-10-28 14:38 ` Jakub Kicinski
2021-11-01 7:04 ` Tony Lu
2021-11-02 9:17 ` Karsten Graul
2021-11-03 3:06 ` Tony Lu
2021-11-06 12:46 ` Karsten Graul
2021-10-27 8:52 ` [PATCH net 2/4] net/smc: Fix smc_link->llc_testlink_time overflow Tony Lu
2021-10-27 10:24 ` Karsten Graul
2021-10-28 6:52 ` Tony Lu [this message]
2021-10-27 8:52 ` [PATCH net 3/4] net/smc: Correct spelling mistake to TCPF_SYN_RECV Tony Lu
2021-10-27 10:23 ` Karsten Graul
2021-10-28 6:53 ` Tony Lu
2021-10-27 8:52 ` [PATCH net 4/4] net/smc: Fix wq mismatch issue caused by smc fallback Tony Lu
2021-10-28 14:16 ` Karsten Graul
2021-10-29 9:40 ` Karsten Graul
2021-11-01 6:15 ` Wen Gu
2021-11-02 9:25 ` Karsten Graul
2021-11-03 8:56 ` Wen Gu
2021-11-04 4:39 ` Wen Gu
2021-11-06 12:51 ` Karsten Graul
2021-11-10 12:50 ` Wen Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXpImWvmdMkK2wd0@TonyMac-Alibaba \
--to=tonylu@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=guwen@linux.alibaba.com \
--cc=jacob.qi@linux.alibaba.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ubraun@linux.ibm.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).