public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: sundeep subbaraya <sundeep.lkml@gmail.com>
Cc: Sunil Kovvuri Goutham <sgoutham@marvell.com>,
	Jakub Kicinski <kuba@kernel.org>,
	David Miller <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Hariprasad Kelam <hkelam@marvell.com>,
	Geethasowjanya Akula <gakula@marvell.com>,
	Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
	Rakesh Babu Saladi <rsaladi2@marvell.com>,
	Saeed Mahameed <saeed@kernel.org>,
	"anthony.l.nguyen@intel.com" <anthony.l.nguyen@intel.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Andrew Lunn <andrew@lunn.ch>
Subject: Re: [EXT] Re: [net-next PATCH 1/2] octeontx2-pf: Add devlink param to init and de-init serdes
Date: Thu, 28 Oct 2021 16:51:19 +0300	[thread overview]
Message-ID: <YXqq19HxleZd6V9W@shredder> (raw)
In-Reply-To: <CALHRZuqpaqvunTga+8OK4GSa3oRao-CBxit6UzRvN3a1-T0dhA@mail.gmail.com>

On Thu, Oct 28, 2021 at 05:48:02PM +0530, sundeep subbaraya wrote:
> Actually we also need a case where debugging is required when the
> logical link is
> up (so that packets flow from kernel to SerDes continuously) but the
> physical link
> is down. 

Can you explain the motivation for that? In the past we discussed use
cases for forcing the operational state to down while the administrative
state is up and couldn't find any.

> We will change the commit description since it is giving the
> wrong impression.
> A command to change physical link up/down with no relation to ifconfig
> is needed.

So it is obvious that some drivers default to not shutting down the
physical link upon admin down, but that some users want to change that.
In addition, we have your use case to control the physical link without
relation to the logical link. I wonder if it can all be solved with a
new ethtool attribute (part of LINKINFO_{SET,GET} ?) that describes the
physical link policy and has the following values:

* auto: Physical link state is derived from logical link state
* up: Physical link state is always up
* down: Physical link state is always down

IIUC, it should solve your problem and that of the "link-down-on-close"
private flag. It also has the added benefit of allowing user space to
query the default policy. The expectation is that it would be "auto",
but in some scenarios it is "up".

  reply	other threads:[~2021-10-28 13:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 10:31 [net-next PATCH 0/2] Add a devlink param and documentation Subbaraya Sundeep
2021-10-27 10:31 ` [net-next PATCH 1/2] octeontx2-pf: Add devlink param to init and de-init serdes Subbaraya Sundeep
2021-10-27 15:38   ` Jakub Kicinski
     [not found]     ` <PH0PR18MB4671C22DB7C8E5C46647860FA1859@PH0PR18MB4671.namprd18.prod.outlook.com>
2021-10-27 16:43       ` Fw: [EXT] " sundeep subbaraya
2021-10-27 17:08         ` Jakub Kicinski
2021-10-27 18:11           ` Ido Schimmel
     [not found]             ` <BY3PR18MB473794E01049EC94156E2858C6859@BY3PR18MB4737.namprd18.prod.outlook.com>
2021-10-27 22:24               ` Ido Schimmel
2021-10-28 12:18                 ` sundeep subbaraya
2021-10-28 13:51                   ` Ido Schimmel [this message]
2021-10-30  7:25                     ` sundeep subbaraya
2021-11-07  9:21                       ` Ido Schimmel
2021-11-08 15:54                         ` Jakub Kicinski
2021-11-11 14:51                           ` Ido Schimmel
2021-11-11 16:47                             ` Jakub Kicinski
2021-11-14  8:38                               ` Ido Schimmel
2021-11-15  4:19                                 ` Roopa Prabhu
2021-11-15 15:11                                   ` Jakub Kicinski
2021-11-19 10:47                                     ` sundeep subbaraya
2021-11-19 14:09                                       ` Jakub Kicinski
2021-11-19 14:26                                         ` sundeep subbaraya
2021-11-19 14:49                                           ` Jakub Kicinski
2021-10-27 10:31 ` [net-next PATCH 2/2] devlink: add documentation for octeontx2 driver Subbaraya Sundeep
2021-10-27 15:39   ` Jakub Kicinski
     [not found]     ` <PH0PR18MB46711B24C7305B8488266C8CA1859@PH0PR18MB4671.namprd18.prod.outlook.com>
2021-10-27 17:04       ` Fw: [EXT] " sundeep subbaraya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXqq19HxleZd6V9W@shredder \
    --to=idosch@idosch.org \
    --cc=andrew@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=gakula@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rsaladi2@marvell.com \
    --cc=saeed@kernel.org \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    --cc=sundeep.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox