From: Andrew Lunn <andrew@lunn.ch>
To: Yuiko Oshino <yuiko.oshino@microchip.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net] net: ethernet: microchip: lan743x: Increase rx ring size to improve rx performance
Date: Thu, 28 Oct 2021 18:03:17 +0200 [thread overview]
Message-ID: <YXrJxb0LtllPkOse@lunn.ch> (raw)
In-Reply-To: <20211028150315.19270-1-yuiko.oshino@microchip.com>
On Thu, Oct 28, 2021 at 11:03:15AM -0400, Yuiko Oshino wrote:
> Increase the rx ring size (LAN743X_RX_RING_SIZE) to improve rx performance on some platforms.
> Tested on x86 PC with EVB-LAN7430.
> The iperf3.7 TCPIP improved from 881 Mbps to 922 Mbps, and UDP improved from 817 Mbps to 936 Mbps.
>
> Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
> Signed-off-by: Yuiko Oshino <yuiko.oshino@microchip.com>
> ---
> drivers/net/ethernet/microchip/lan743x_main.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/microchip/lan743x_main.h b/drivers/net/ethernet/microchip/lan743x_main.h
> index 34c22eea0124..aaf7aaeaba0c 100644
> --- a/drivers/net/ethernet/microchip/lan743x_main.h
> +++ b/drivers/net/ethernet/microchip/lan743x_main.h
> @@ -831,7 +831,7 @@ struct lan743x_rx_buffer_info {
> unsigned int buffer_length;
> };
>
> -#define LAN743X_RX_RING_SIZE (65)
65 is interesting. 2^N + 1. So there might be a reason for this?
> +#define LAN743X_RX_RING_SIZE (128)
129?
Andrew
next prev parent reply other threads:[~2021-10-28 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 15:03 [PATCH net] net: ethernet: microchip: lan743x: Increase rx ring size to improve rx performance Yuiko Oshino
2021-10-28 15:13 ` Jakub Kicinski
2021-10-28 15:17 ` Yuiko.Oshino
2021-10-28 16:03 ` Andrew Lunn [this message]
2021-10-29 12:57 ` Yuiko.Oshino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXrJxb0LtllPkOse@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yuiko.oshino@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).