From: Andrea Righi <andrea.righi@canonical.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: net: properly support IPv6 in GSO GRE test
Date: Thu, 11 Nov 2021 16:31:17 +0100 [thread overview]
Message-ID: <YY03RcYshbQFJBRb@arighi-desktop> (raw)
In-Reply-To: <20211111072048.00852448@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, Nov 11, 2021 at 07:20:48AM -0800, Jakub Kicinski wrote:
> On Thu, 4 Nov 2021 11:46:13 +0100 Andrea Righi wrote:
> > Explicitly pass -6 to netcat when the test is using IPv6 to prevent
> > failures.
> >
> > Also make sure to pass "-N" to netcat to close the socket after EOF on
> > the client side, otherwise we would always hit the timeout and the test
> > would fail.
> >
> > Without this fix applied:
> >
> > TEST: GREv6/v4 - copy file w/ TSO [FAIL]
> > TEST: GREv6/v4 - copy file w/ GSO [FAIL]
> > TEST: GREv6/v6 - copy file w/ TSO [FAIL]
> > TEST: GREv6/v6 - copy file w/ GSO [FAIL]
> >
> > With this fix applied:
> >
> > TEST: GREv6/v4 - copy file w/ TSO [ OK ]
> > TEST: GREv6/v4 - copy file w/ GSO [ OK ]
> > TEST: GREv6/v6 - copy file w/ TSO [ OK ]
> > TEST: GREv6/v6 - copy file w/ GSO [ OK ]
> >
> > Fixes: 025efa0a82df ("selftests: add simple GSO GRE test")
> > Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
>
> This breaks the test for me on Fedora now :(
Oops, sorry about that.
>
> nc: invalid option -- 'N'
> Ncat: Try `--help' or man(1) ncat for more information, usage options and help. QUITTING.
> TEST: GREv6/v4 - copy file w/ TSO [FAIL]
> nc: invalid option -- 'N'
> Ncat: Try `--help' or man(1) ncat for more information, usage options and help. QUITTING.
> TEST: GREv6/v4 - copy file w/ GSO [FAIL]
> nc: invalid option -- 'N'
> Ncat: Try `--help' or man(1) ncat for more information, usage options and help. QUITTING.
> TEST: GREv6/v6 - copy file w/ TSO [FAIL]
> nc: invalid option -- 'N'
> Ncat: Try `--help' or man(1) ncat for more information, usage options and help. QUITTING.
> TEST: GREv6/v6 - copy file w/ GSO [FAIL]
>
> Tests passed: 0
> Tests failed: 4
>
>
> Can you please test this on your distro?
Tested, it works fine in Ubuntu as well:
$ sudo ./tools/testing/selftests/net/gre_gso.sh
TEST: GREv6/v4 - copy file w/ TSO [ OK ]
TEST: GREv6/v4 - copy file w/ GSO [ OK ]
TEST: GREv6/v6 - copy file w/ TSO [ OK ]
TEST: GREv6/v6 - copy file w/ GSO [ OK ]
Tests passed: 4
Tests failed: 0
Tested-by: Andrea Righi <andrea.righi@canonical.com>
prev parent reply other threads:[~2021-11-11 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 10:46 [PATCH] selftests: net: properly support IPv6 in GSO GRE test Andrea Righi
2021-11-04 11:30 ` patchwork-bot+netdevbpf
2021-11-11 15:20 ` Jakub Kicinski
2021-11-11 15:31 ` Andrea Righi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY03RcYshbQFJBRb@arighi-desktop \
--to=andrea.righi@canonical.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox