Netdev List
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	"Andrea Mayer" <andrea.mayer@uniroma2.it>,
	"Coco Li" <lixiaoyan@google.com>,
	"Paolo Lungaroni" <paolo.lungaroni@uniroma2.it>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCHv2 net 5/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh to Makefile
Date: Wed, 3 Nov 2021 10:42:51 +0800	[thread overview]
Message-ID: <YYH3K1zJmissyL7F@Laptop-X1> (raw)
In-Reply-To: <CA+FuTSeS2s7czeAASfz9qep06gdUKVHD8bhiqtEOS1w82-JR7Q@mail.gmail.com>

On Tue, Nov 02, 2021 at 11:09:43AM -0400, Willem de Bruijn wrote:
> On Mon, Nov 1, 2021 at 9:37 PM Hangbin Liu <liuhangbin@gmail.com> wrote:
> >
> > When generating the selftests to another folder, the toeplitz.sh
> > and toeplitz_client.sh are missing as they are not in Makefile, e.g.
> >
> >   make -C tools/testing/selftests/ install \
> >       TARGETS="net" INSTALL_PATH=/tmp/kselftests
> >
> > Making them under TEST_PROGS_EXTENDED as they test NIC hardware features
> > and are not intended to be run from kselftests.
> >
> > Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test")
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> 
> Reviewed-by: Willem de Bruijn <willemb@google.com>

Thanks for the review.
> 
> The same might apply to the icmp and vrf tests? I am not familiar with those.

icmp and vrf are running for selftests. They should be added to TEST_PROGS.

Thanks
Hangbin

  reply	other threads:[~2021-11-03  2:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02  1:36 [PATCHv2 net 0/5] kselftests/net: add missed tests to Makefile Hangbin Liu
2021-11-02  1:36 ` [PATCHv2 net 1/5] kselftests/net: add missed icmp.sh test " Hangbin Liu
2021-11-02  1:36 ` [PATCHv2 net 2/5] kselftests/net: add missed setup_loopback.sh/setup_veth.sh " Hangbin Liu
2021-11-02  1:36 ` [PATCHv2 net 3/5] kselftests/net: add missed SRv6 tests Hangbin Liu
2021-11-02  1:36 ` [PATCHv2 net 4/5] kselftests/net: add missed vrf_strict_mode_test.sh test to Makefile Hangbin Liu
2021-11-02  1:36 ` [PATCHv2 net 5/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh " Hangbin Liu
2021-11-02 15:09   ` Willem de Bruijn
2021-11-03  2:42     ` Hangbin Liu [this message]
2021-11-02 18:16 ` [PATCHv2 net 0/5] kselftests/net: add missed tests " Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYH3K1zJmissyL7F@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=andrea.mayer@uniroma2.it \
    --cc=davem@davemloft.net \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lixiaoyan@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=paolo.lungaroni@uniroma2.it \
    --cc=toke@redhat.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox