From: Dominique Martinet <asmadeus@codewreck.org>
To: "Thomas Weißschuh" <thomas@t-8ch.de>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Eric Van Hensbergen" <ericvh@gmail.com>,
"Latchesar Ionkov" <lucho@ionkov.net>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/9p: autoload transport modules
Date: Wed, 3 Nov 2021 10:00:12 +0900 [thread overview]
Message-ID: <YYHfHIcVSDOSuJnx@codewreck.org> (raw)
In-Reply-To: <YYHXOOwkmJW8bhHW@codewreck.org>
Dominique Martinet wrote on Wed, Nov 03, 2021 at 09:26:32AM +0900:
> Feel free to resend in a proper form though, I could make up a commit
> message but it might as well be your words!
Ah, just a couple more things:
* make with W=1 complains about missing prototypes:
net/9p/trans_fd.c:1155:5: warning: no previous prototype for ‘p9_trans_fd_init’ [-Wmissing-prototypes]
1155 | int p9_trans_fd_init(void)
| ^~~~~~~~~~~~~~~~
net/9p/trans_fd.c:1164:6: warning: no previous prototype for ‘p9_trans_fd_exit’ [-Wmissing-prototypes]
1164 | void p9_trans_fd_exit(void)
| ^~~~~~~~~~~~~~~~
* This actually break the 'no trans=tcp' specified case when no extra
module is loaded, but I'm not sure how impactful that is.
See v9fs_get_default_trans(), they iterate through loaded transports
(through register_trans()), we might want to bake in a list that
additionally tries to load modules if no module is loaded at all
(in my opinion virtio makes sense before tcp, then fd, unix, xen, rdma?)
Well, that can probably come later.
--
Dominique
prev parent reply other threads:[~2021-11-03 1:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 13:46 [PATCH] net/9p: autoload transport modules Thomas Weißschuh
2021-11-02 10:51 ` Dominique Martinet
2021-11-02 10:59 ` Thomas Weißschuh
2021-11-02 11:51 ` Dominique Martinet
2021-11-02 14:49 ` Thomas Weißschuh
2021-11-02 14:58 ` Dominique Martinet
2021-11-02 15:32 ` Thomas Weißschuh
2021-11-02 23:17 ` Dominique Martinet
2021-11-02 23:33 ` Thomas Weißschuh
2021-11-03 0:26 ` Dominique Martinet
2021-11-03 1:00 ` Dominique Martinet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYHfHIcVSDOSuJnx@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=thomas@t-8ch.de \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).