From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Dylan Hung <dylan_hung@aspeedtech.com>
Cc: linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
andrew@aj.id.au, joel@jms.id.au, kuba@kernel.org,
davem@davemloft.net, hkallweit1@gmail.com, andrew@lunn.ch,
BMC-SW@aspeedtech.com, stable@vger.kernel.org
Subject: Re: [PATCH v2] mdio: aspeed: Fix "Link is Down" issue
Date: Thu, 25 Nov 2021 15:35:36 +0000 [thread overview]
Message-ID: <YZ+tSMT4Z6CpOgJ3@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211125024432.15809-1-dylan_hung@aspeedtech.com>
On Thu, Nov 25, 2021 at 10:44:32AM +0800, Dylan Hung wrote:
> The issue happened randomly in runtime. The message "Link is Down" is
> popped but soon it recovered to "Link is Up".
>
> The "Link is Down" results from the incorrect read data for reading the
> PHY register via MDIO bus. The correct sequence for reading the data
> shall be:
> 1. fire the command
> 2. wait for command done (this step was missing)
> 3. wait for data idle
> 4. read data from data register
>
> Fixes: f160e99462c6 ("net: phy: Add mdio-aspeed")
> Cc: stable@vger.kernel.org
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-11-25 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 2:44 [PATCH v2] mdio: aspeed: Fix "Link is Down" issue Dylan Hung
2021-11-25 14:47 ` Andrew Lunn
2021-11-25 15:35 ` Russell King (Oracle) [this message]
2021-11-25 16:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ+tSMT4Z6CpOgJ3@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dylan_hung@aspeedtech.com \
--cc=hkallweit1@gmail.com \
--cc=joel@jms.id.au \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).