From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5CF7C433F5 for ; Tue, 23 Nov 2021 18:06:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239498AbhKWSJ2 (ORCPT ); Tue, 23 Nov 2021 13:09:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbhKWSJ0 (ORCPT ); Tue, 23 Nov 2021 13:09:26 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB874C061574 for ; Tue, 23 Nov 2021 10:06:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KYSi2DF32RnDnLuMXUFwS6/JUsWTjaNgU1Zqsf1R994=; b=Q5EHUvbmG2iGLExtA+9E0hXBPX 3bEBtvn8q4WfYp21EJUV/yI1Q+zUeF/FKkATbjqhc+mmPCW0q7wP7/Tz2q6LilCaAfKCTT4a+PIKO y5u2Eucfj2z2x1wB28DccX9Pn/GR5XlY74Q+WZYeLIyY0rOIq+b/1UGWLhZhu4PXPSP4VZzG92unn 57e3TEhIDGq6q5trzwZiYmLAnITJEyMpN3v6KpVNTgSQpfCvn8U+y9/HdT+lES8igOQL1+4oM3L+u MM6FwEKr5LD06Q7Vuna0+wDsWJC5xn4cV2/rj34zAL98P/lsXQglR5ma3czDKrLRJFus07/0oOMmm Zd+ncwwA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55822) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mpaBB-0008F7-60; Tue, 23 Nov 2021 18:06:05 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mpaB5-0000QM-B9; Tue, 23 Nov 2021 18:05:59 +0000 Date: Tue, 23 Nov 2021 18:05:59 +0000 From: "Russell King (Oracle)" To: Chris Snook , Felix Fietkau , Florian Fainelli , John Crispin , Mark Lee , Matthias Brugger , Michal Simek , Radhey Shyam Pandey , Sean Wang , Vivien Didelot , Vladimir Oltean Cc: Andrew Lunn , "David S. Miller" , Heiner Kallweit , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH RFC net-next 5/8] net: ag71xx: mark as a legacy_pre_march2020 phylink driver Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 23, 2021 at 10:00:34AM +0000, Russell King (Oracle) wrote: > ag71xx has a PCS, but does not make use of the phylink PCS support. > Mark it was a pre-March 2020 driver. > > Signed-off-by: Russell King (Oracle) Hi, I've just been looking closer at this driver, and it seems that we can drop the "legacy_pre_march2020" flag, and in doing so, delete the ag71xx_mac_pcs_get_state and ag71xx_mac_an_restart functions entirely, removing them from ag71xx_phylink_mac_ops. Should this driver need to deal with the PCS - in other words, to modify the advertisement, then it will need to make use of the phylink_pcs support. I'll send a v2 in a day or two. Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!