From: Matthias Kaehlcke <mka@chromium.org>
To: Alex Elder <elder@linaro.org>
Cc: davem@davemloft.net, kuba@kernel.org, pkurapat@codeaurora.org,
avuyyuru@codeaurora.org, bjorn.andersson@linaro.org,
cpratapa@codeaurora.org, subashab@codeaurora.org,
evgreen@chromium.org, elder@kernel.org, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: ipa: directly disable ipa-setup-ready interrupt
Date: Wed, 24 Nov 2021 10:37:01 -0800 [thread overview]
Message-ID: <YZ6GTe3wUU7PbI/W@google.com> (raw)
In-Reply-To: <20211123001555.505546-2-elder@linaro.org>
On Mon, Nov 22, 2021 at 06:15:54PM -0600, Alex Elder wrote:
> We currently maintain a "disabled" Boolean flag to determine whether
> the "ipa-setup-ready" SMP2P IRQ handler does anything. That flag
> must be accessed under protection of a mutex.
>
> Instead, disable the SMP2P interrupt when requested, which prevents
> the interrupt handler from ever being called. More importantly, it
> synchronizes a thread disabling the interrupt with the completion of
> the interrupt handler in case they run concurrently.
>
> Use the IPA setup_complete flag rather than the disabled flag in the
> handler to determine whether to ignore any interrupts arriving after
> the first.
>
> Rename the "disabled" flag to be "setup_disabled", to be specific
> about its purpose.
>
> Fixes: 530f9216a953 ("soc: qcom: ipa: AP/modem communications")
> Signed-off-by: Alex Elder <elder@linaro.org>
I don't claim to know much about IPA, but this looks reasonable to me.
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2021-11-24 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 0:15 [PATCH net 0/2] net: ipa: prevent shutdown during setup Alex Elder
2021-11-23 0:15 ` [PATCH net 1/2] net: ipa: directly disable ipa-setup-ready interrupt Alex Elder
2021-11-24 18:37 ` Matthias Kaehlcke [this message]
2021-11-23 0:15 ` [PATCH net 2/2] net: ipa: separate disabling setup from modem stop Alex Elder
2021-11-23 12:20 ` [PATCH net 0/2] net: ipa: prevent shutdown during setup patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ6GTe3wUU7PbI/W@google.com \
--to=mka@chromium.org \
--cc=avuyyuru@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkurapat@codeaurora.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).