[PATCH net-next] net: phy: add support for TI DP83561-SP phy

[PATCH net-next] net: phy: add support for TI DP83561-SP phy

[hnagalla]

From: Hari Nagalla <hnagalla@ti.com>

Add support for the TI DP83561-SP Gigabit ethernet phy device.

The dp83561-sp is a high reliability gigabit ethernet PHY designed for
the high-radiation environment of space. It interfaces directly to
twisted pair media through an external transformer. The device
interfaces directly to the MAC layer through Reduced GMII (RGMII) and MII.

DP83867, DP83869 and DP83561-SP, all these parts support 1000Base-T/
100Base-TX/ and 10Base-Te standards and have similar register map for
the core functionality.

The data sheet for this part is at https://www.ti.com/product/DP83561-SP

Signed-off-by: Hari Nagalla <hnagalla@ti.com>
Signed-off-by: Geet Modi <geet.modi@ti.com>
---
 drivers/net/phy/dp83869.c | 42 ++++++++++++++++++++-------------------
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
index 7113925606f7..b4ff9c5073a3 100644
--- a/drivers/net/phy/dp83869.c
+++ b/drivers/net/phy/dp83869.c
@@ -16,6 +16,7 @@
 #include <dt-bindings/net/ti-dp83869.h>
 
 #define DP83869_PHY_ID		0x2000a0f1
+#define DP83561_PHY_ID		0x2000a1a4
 #define DP83869_DEVADDR		0x1f
 
 #define MII_DP83869_PHYCTRL	0x10
@@ -878,34 +879,35 @@ static int dp83869_phy_reset(struct phy_device *phydev)
 	return dp83869_config_init(phydev);
 }
 
-static struct phy_driver dp83869_driver[] = {
-	{
-		PHY_ID_MATCH_MODEL(DP83869_PHY_ID),
-		.name		= "TI DP83869",
-
-		.probe          = dp83869_probe,
-		.config_init	= dp83869_config_init,
-		.soft_reset	= dp83869_phy_reset,
-
-		/* IRQ related */
-		.config_intr	= dp83869_config_intr,
-		.handle_interrupt = dp83869_handle_interrupt,
-		.read_status	= dp83869_read_status,
 
-		.get_tunable	= dp83869_get_tunable,
-		.set_tunable	= dp83869_set_tunable,
+#define DP83869_PHY_DRIVER(_id, _name)				\
+{								\
+	PHY_ID_MATCH_MODEL(_id),				\
+	.name		= (_name),				\
+	.probe          = dp83869_probe,			\
+	.config_init	= dp83869_config_init,			\
+	.soft_reset	= dp83869_phy_reset,			\
+	.config_intr	= dp83869_config_intr,			\
+	.handle_interrupt = dp83869_handle_interrupt,		\
+	.read_status	= dp83869_read_status,			\
+	.get_tunable	= dp83869_get_tunable,			\
+	.set_tunable	= dp83869_set_tunable,			\
+	.get_wol	= dp83869_get_wol,			\
+	.set_wol	= dp83869_set_wol,			\
+	.suspend	= genphy_suspend,			\
+	.resume		= genphy_resume,			\
+}
 
-		.get_wol	= dp83869_get_wol,
-		.set_wol	= dp83869_set_wol,
+static struct phy_driver dp83869_driver[] = {
+	DP83869_PHY_DRIVER(DP83869_PHY_ID, "TI DP83869"),
+	DP83869_PHY_DRIVER(DP83561_PHY_ID, "TI DP83561-SP"),
 
-		.suspend	= genphy_suspend,
-		.resume		= genphy_resume,
-	},
 };
 module_phy_driver(dp83869_driver);
 
 static struct mdio_device_id __maybe_unused dp83869_tbl[] = {
 	{ PHY_ID_MATCH_MODEL(DP83869_PHY_ID) },
+	{ PHY_ID_MATCH_MODEL(DP83561_PHY_ID) },
 	{ }
 };
 MODULE_DEVICE_TABLE(mdio, dp83869_tbl);
-- 
2.17.1

Re: [PATCH net-next] net: phy: add support for TI DP83561-SP phy

[Andrew Lunn]

On Tue, Nov 16, 2021 at 04:20:15AM -0600, hnagalla@ti.com wrote:
> From: Hari Nagalla <hnagalla@ti.com>
> 
> Add support for the TI DP83561-SP Gigabit ethernet phy device.
> 
> The dp83561-sp is a high reliability gigabit ethernet PHY designed for

Does anybody manufacture low reliability devices? Please avoid
meaningless Marketing.

Please add my Reviewed-by: Andrew Lunn <andrew@lunn.ch> to version 2.

    Andrew

Re: [EXTERNAL] Re: [PATCH net-next] net: phy: add support for TI DP83561-SP phy

[Andrew Lunn]

On Tue, Nov 16, 2021 at 03:58:27PM +0000, Modi, Geet wrote:
> Hello Andrew,
> 
>  
> 
> We being Texas Instruments are conservative and don't promote meaningless
> marketing as well. Please note DP83561-SP is a Radiation Hardened Space Grade
> Gigabit PHY. It has been tested for Single Event Latch up upto 121 MeV, the
> critical reliability parameter Space Designs look for.

That statement i have no problems with, it is clearly factual.

> The dp83561-sp is a high reliability gigabit ethernet PHY designed

is clearly Marketing, who would design a low reliability gigabit
ethernet PHY? It is meaningless.

So please use your text from above in the commit message, it nicely
describes what this PHY is in engineering terms.

   Andrew

Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH net-next] net: phy: add support for TI DP83561-SP phy

[Modi, Geet]

Thanks Andrew. 

Hari, please update the commit message and re-submit.


Regards,
Geet

On 11/16/21, 8:15 AM, "Andrew Lunn" <andrew@lunn.ch> wrote:

    On Tue, Nov 16, 2021 at 03:58:27PM +0000, Modi, Geet wrote:
    > Hello Andrew,
    > 
    >  
    > 
    > We being Texas Instruments are conservative and don't promote meaningless
    > marketing as well. Please note DP83561-SP is a Radiation Hardened Space Grade
    > Gigabit PHY. It has been tested for Single Event Latch up upto 121 MeV, the
    > critical reliability parameter Space Designs look for.

    That statement i have no problems with, it is clearly factual.

    > The dp83561-sp is a high reliability gigabit ethernet PHY designed

    is clearly Marketing, who would design a low reliability gigabit
    ethernet PHY? It is meaningless.

    So please use your text from above in the commit message, it nicely
    describes what this PHY is in engineering terms.

       Andrew