From: Hangbin Liu <liuhangbin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Jarod Wilson <jarod@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
"David S . Miller" <davem@davemloft.net>,
Denis Kirjanov <dkirjanov@suse.de>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next] Bonding: add missed_max option
Date: Wed, 17 Nov 2021 09:01:15 +0800 [thread overview]
Message-ID: <YZRUW6wfMdI1aN1o@Laptop-X1> (raw)
In-Reply-To: <20211116120058.494d6204@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Tue, Nov 16, 2021 at 12:00:58PM -0800, Jakub Kicinski wrote:
> On Tue, 16 Nov 2021 16:48:40 +0800 Hangbin Liu wrote:
> > + [IFLA_BOND_MISSED_MAX] = { .type = NLA_U32 },
>
> Why NLA_U32...
>
> >
> > static const struct nla_policy bond_slave_policy[IFLA_BOND_SLAVE_MAX + 1] = {
> > @@ -453,6 +454,15 @@ static int bond_changelink(struct net_device *bond_dev, struct nlattr *tb[],
> > return err;
> > }
> >
> > + if (data[IFLA_BOND_MISSED_MAX]) {
> > + int missed_max = nla_get_u8(data[IFLA_BOND_MISSED_MAX]);
>
> If you read and write a u8?
Ah, that's a typo. I planed to use nla_get_u32(). But looks NLA_U8 also should
be enough. WDYT?
Thanks
Hangbin
next prev parent reply other threads:[~2021-11-17 1:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 8:48 [PATCH net-next] Bonding: add missed_max option Hangbin Liu
2021-11-16 8:49 ` [PATCH iproute2-next] bond: " Hangbin Liu
2021-11-16 20:00 ` [PATCH net-next] Bonding: " Jakub Kicinski
2021-11-17 1:01 ` Hangbin Liu [this message]
2021-11-17 2:41 ` Jakub Kicinski
2021-11-17 7:20 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZRUW6wfMdI1aN1o@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dkirjanov@suse.de \
--cc=dsahern@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=jarod@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox