netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Jay Vosburgh <jay.vosburgh@canonical.com>
Cc: netdev@vger.kernel.org, Veaceslav Falico <vfalico@gmail.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	Jarod Wilson <jarod@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
	Jiri Pirko <jiri@resnulli.us>,
	davem@davemloft.net, Denis Kirjanov <dkirjanov@suse.de>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCHv2 net-next] Bonding: add missed_max option
Date: Wed, 17 Nov 2021 17:58:42 +0800	[thread overview]
Message-ID: <YZTSUh0vA1gVZFr3@Laptop-X1> (raw)
In-Reply-To: <70666.1637138425@nyx>

On Wed, Nov 17, 2021 at 08:40:25AM +0000, Jay Vosburgh wrote:
> Hangbin Liu <liuhangbin@gmail.com> wrote:
> 
> >Currently, we use hard code number to verify if we are in the
> >arp_interval timeslice. But some user may want to reduce/extend
> >the verify timeslice. With the similar team option 'missed_max'
> >the uers could change that number based on their own environment.
> >
> >The name of arp_misssed_max is not used as we may use this option for
> >Bonding IPv6 NS/NA monitor in future.
> 
> 	Why reserve "arp_missed_max" for IPv6 which doesn't use ARP?  If
> the option is for the ARP monitor, then prefixing it with "arp_" would
> be consistent with the other arp_* options.

I didn't explain it clearly. I want to say:

I'm not using arp_misssed_max as the new option name because I plan to add
bonding IPv6 NS/NA monitor in future. At that time the option "missed_max"
could be used for both IPv4/IPv6 monitor.

I will update the commit description in next version.

Thanks
Hangbin

  reply	other threads:[~2021-11-17  9:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17  8:03 [PATCHv2 net-next] Bonding: add missed_max option Hangbin Liu
2021-11-17  8:03 ` [PATCHv2 iproute2-next] bond: " Hangbin Liu
2021-11-17  8:40 ` [PATCHv2 net-next] Bonding: " Jay Vosburgh
2021-11-17  9:58   ` Hangbin Liu [this message]
2021-11-17 16:16     ` Jay Vosburgh
2021-11-18  1:13       ` Hangbin Liu
2021-11-18 14:10         ` Jay Vosburgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZTSUh0vA1gVZFr3@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=dkirjanov@suse.de \
    --cc=dsahern@gmail.com \
    --cc=jarod@redhat.com \
    --cc=jay.vosburgh@canonical.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).