public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Jay Vosburgh <jay.vosburgh@canonical.com>
Cc: netdev@vger.kernel.org, Veaceslav Falico <vfalico@gmail.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	Jarod Wilson <jarod@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
	Jiri Pirko <jiri@resnulli.us>,
	davem@davemloft.net, Denis Kirjanov <dkirjanov@suse.de>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCHv2 net-next] Bonding: add missed_max option
Date: Thu, 18 Nov 2021 09:13:07 +0800	[thread overview]
Message-ID: <YZWooyiGT9Z3mPwh@Laptop-X1> (raw)
In-Reply-To: <86277.1637165806@nyx>

On Wed, Nov 17, 2021 at 04:16:46PM +0000, Jay Vosburgh wrote:
> >I didn't explain it clearly. I want to say:
> >
> >I'm not using arp_misssed_max as the new option name because I plan to add
> >bonding IPv6 NS/NA monitor in future. At that time the option "missed_max"
> >could be used for both IPv4/IPv6 monitor.
> >
> >I will update the commit description in next version.
> 
> 	There has been talk of adding an IPv6 NS monitor for years, but
> it hasn't manifested.  I would prefer to see a consistent set of options

I'm working on it now. I should send a simple draft patch in 2 weeks.

> nomenclature in what we have here and now.  If and when an IPv6 version
> is added, depending on the implementation, either the IPv6 item can be a
> discrete tunable, or an alias could be added, similar to num_grat_arp /
> num_unsol_na.

The name of num_grat_arp looks better than missed_max :) . In my
IPv6 implementation, the function bond_ab_arp_inspect() will be reused
directly. So one name or an alias looks more reasonable.

For the alias options, do you mean to let both num_grat_arp and num_unsol_na
change a same option in bond->params?

Thanks
Hangbin

  reply	other threads:[~2021-11-18  1:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17  8:03 [PATCHv2 net-next] Bonding: add missed_max option Hangbin Liu
2021-11-17  8:03 ` [PATCHv2 iproute2-next] bond: " Hangbin Liu
2021-11-17  8:40 ` [PATCHv2 net-next] Bonding: " Jay Vosburgh
2021-11-17  9:58   ` Hangbin Liu
2021-11-17 16:16     ` Jay Vosburgh
2021-11-18  1:13       ` Hangbin Liu [this message]
2021-11-18 14:10         ` Jay Vosburgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZWooyiGT9Z3mPwh@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=dkirjanov@suse.de \
    --cc=dsahern@gmail.com \
    --cc=jarod@redhat.com \
    --cc=jay.vosburgh@canonical.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox