From: Hangbin Liu <liuhangbin@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <jay.vosburgh@canonical.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Jarod Wilson <jarod@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Jiri Pirko <jiri@resnulli.us>,
davem@davemloft.net, Denis Kirjanov <dkirjanov@suse.de>,
David Ahern <dsahern@gmail.com>
Subject: Re: [DISCUSS] Bond arp monitor not works with veth due to flag NETIF_F_LLTX.
Date: Thu, 18 Nov 2021 18:17:14 +0800 [thread overview]
Message-ID: <YZYoKuvrZmHEiQGx@Laptop-X1> (raw)
In-Reply-To: <CANn89iLKKX7+opENOa2oQpH_JmpPYeDPZtb+srYF2O3UgdUT5g@mail.gmail.com>
On Wed, Nov 17, 2021 at 07:34:40PM -0800, Eric Dumazet wrote:
> Removing LLTX will have performance impact.
Yes, I also think so.
>
> Updating ->trans_start at most once per jiffy should be ok.
>
> Here is a patch against net-next
> @@ -4626,7 +4620,7 @@ static inline netdev_tx_t
> netdev_start_xmit(struct sk_buff *skb, struct net_devi
>
> rc = __netdev_start_xmit(ops, skb, dev, more);
> if (rc == NETDEV_TX_OK)
> - txq_trans_update(txq);
> + txq_trans_cond_update(txq);
>
> return rc;
> }
Awesome. This should resolve the veth's trans_start issue. Where is the patch?
I only find out the following one but could not find the fix in netdev_start_xmit()
https://patchwork.kernel.org/project/netdevbpf/patch/20211117032924.1740327-3-eric.dumazet@gmail.com/
Thanks
Hangbin
prev parent reply other threads:[~2021-11-18 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 3:11 [DISCUSS] Bond arp monitor not works with veth due to flag NETIF_F_LLTX Hangbin Liu
2021-11-18 3:34 ` Eric Dumazet
2021-11-18 10:17 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZYoKuvrZmHEiQGx@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dkirjanov@suse.de \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=jarod@redhat.com \
--cc=jay.vosburgh@canonical.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox