From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: fw@strlen.de, lschlesinger@drivenets.com, dsahern@kernel.org,
crosser@average.org, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH nf] vrf: don't run conntrack on vrf with !dflt qdisc
Date: Wed, 8 Dec 2021 01:25:19 +0100 [thread overview]
Message-ID: <Ya/7b85COMY2702t@salvia> (raw)
In-Reply-To: <20211126143612.11262-1-nicolas.dichtel@6wind.com>
On Fri, Nov 26, 2021 at 03:36:12PM +0100, Nicolas Dichtel wrote:
> After the below patch, the conntrack attached to skb is set to "notrack" in
> the context of vrf device, for locally generated packets.
> But this is true only when the default qdisc is set to the vrf device. When
> changing the qdisc, notrack is not set anymore.
> In fact, there is a shortcut in the vrf driver, when the default qdisc is
> set, see commit dcdd43c41e60 ("net: vrf: performance improvements for
> IPv4") for more details.
>
> This patch ensures that the behavior is always the same, whatever the qdisc
> is.
>
> To demonstrate the difference, a new test is added in conntrack_vrf.sh.
Applied
prev parent reply other threads:[~2021-12-08 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 14:36 [PATCH nf] vrf: don't run conntrack on vrf with !dflt qdisc Nicolas Dichtel
2021-11-26 14:53 ` Florian Westphal
2021-11-28 18:59 ` David Ahern
2021-12-08 0:25 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya/7b85COMY2702t@salvia \
--to=pablo@netfilter.org \
--cc=crosser@average.org \
--cc=dsahern@kernel.org \
--cc=fw@strlen.de \
--cc=lschlesinger@drivenets.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).