From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8256C433F5 for ; Mon, 6 Dec 2021 16:40:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240510AbhLFQnk (ORCPT ); Mon, 6 Dec 2021 11:43:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239222AbhLFQnh (ORCPT ); Mon, 6 Dec 2021 11:43:37 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 850FFC061354 for ; Mon, 6 Dec 2021 08:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iTcMC0LUFV40Q5Xwv44i5i5oL/WhhroWPQ2G94Oeidg=; b=bpryHtabJJJx3qsVuQZTUfsRH+ sno2dltuogICBsZApxZv92zmWqEspce1MUafGlLmTbGaf8yxk+PC+8LbTPDuVEprHHYIA2IG2n1FS ehilGx3rHCNrIH1zmziSyLtF9YG5oaf7xSYDCpOA4G+BeR8Y+dogb8Yi3U+GNCTmBxnBBXjs5Dvj4 20dO/P3tB4WqJ2IMRlPqOHDIuM7k7LwXwkjIfLonUDqGeAu0eq8K1WSs57ZJa15c3FEWyzuO5vxPC Sa5cUMPh4UEnXj/oK4JC4q0C5OtIuGe2w/lB2oM3tmaohhZrxb3oLFoMQlCZOhLhCB1xq76w1njxK DNLMqt/A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56104) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1muH1z-0004zx-15; Mon, 06 Dec 2021 16:39:59 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1muH1x-0004Ux-HS; Mon, 06 Dec 2021 16:39:57 +0000 Date: Mon, 6 Dec 2021 16:39:57 +0000 From: "Russell King (Oracle)" To: Tom Lendacky Cc: Florian Fainelli , Andrew Lunn , Heiner Kallweit , Vivien Didelot , Vladimir Oltean , Alexandre Belloni , Claudiu Manoil , George McCollister , Hauke Mehrtens , Kurt Kanzenbach , Vladimir Oltean , Woojung Huh , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH RFC net-next 05/12] net: dsa: bcm_sf2: convert to phylink_generic_validate() Message-ID: References: <6ef4f764-cd91-91bd-e921-407e9d198179@gmail.com> <3b3fed98-0c82-99e9-dc72-09fe01c2bcf3@gmail.com> <24f210a9-54c9-eb0b-af88-a7ad75ce26aa@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Dec 06, 2021 at 10:36:24AM -0600, Tom Lendacky wrote: > On 12/6/21 10:13 AM, Russell King (Oracle) wrote: > > On Mon, Dec 06, 2021 at 09:59:46AM -0600, Tom Lendacky wrote: > > > On 12/4/21 8:52 AM, Russell King (Oracle) wrote: > > > > On Sat, Dec 04, 2021 at 08:59:12AM +0000, Russell King (Oracle) wrote: > > > > > On Fri, Dec 03, 2021 at 08:18:22PM -0800, Florian Fainelli wrote: > > > > > > > > > > > Here's a patch for one of my suggestions above. Tom, I'd appreciate > > > > if you could look at this please. Thanks. > > > > > > I think it's fine to move the setting down. The driver that I was working on > > > at the time only advertised 1000baseKX_Full for 1gpbs (which wasn't in the > > > array and why I added it), so I don't see an issue with moving it down. > > > > > > A quick build and test showed that I was able to successfully connect at 1 > > > gbps. I didn't dive any deeper than that. > > > > Thanks Tom! Can I use that to add your tested-by to this change please? > > Certainly. > > Tested-by: Tom Lendacky Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!