From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Ido Schimmel <idosch@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/6] Allow parallel devlink execution
Date: Tue, 7 Dec 2021 09:29:03 +0200 [thread overview]
Message-ID: <Ya8NPxxn8/OAF4cR@unreal> (raw)
In-Reply-To: <20211206180027.3700d357@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, Dec 06, 2021 at 06:00:27PM -0800, Jakub Kicinski wrote:
> On Sun, 5 Dec 2021 10:22:00 +0200 Leon Romanovsky wrote:
> > This is final piece of devlink locking puzzle, where I remove global
> > mutex lock (devlink_mutex), so we can run devlink commands in parallel.
> >
> > The series starts with addition of port_list_lock, which is needed to
> > prevent locking dependency between netdevsim sysfs and devlink. It
> > follows by the patch that adds context aware locking primitives. Such
> > primitives allow us to make sure that devlink instance is locked and
> > stays locked even during reload operation. The last patches opens
> > devlink to parallel commands.
>
> I'm not okay with assuming that all sub-objects are added when devlink
> is not registered.
But none of the patches in this series assume that.
In devlink_nested_lock() patch [1], I added new marker just to make sure
that we don't lock if this specific command is called in locked context.
+#define DEVLINK_NESTED_LOCK XA_MARK_2
[1] https://lore.kernel.org/all/2b64a2a81995b56fec0231751ff6075020058584.1638690564.git.leonro@nvidia.com/
next prev parent reply other threads:[~2021-12-07 7:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 8:22 [PATCH net-next 0/6] Allow parallel devlink execution Leon Romanovsky
2021-12-05 8:22 ` [PATCH net-next 1/6] devlink: Clean registration of devlink port Leon Romanovsky
2021-12-05 8:22 ` [PATCH net-next 2/6] devlink: Be explicit with devlink port protection Leon Romanovsky
2021-12-05 8:22 ` [PATCH net-next 3/6] devlink: Add devlink nested locking primitive Leon Romanovsky
2021-12-05 8:22 ` [PATCH net-next 4/6] devlink: Require devlink lock during device reload Leon Romanovsky
2021-12-05 8:22 ` [PATCH net-next 5/6] devlink: Use xarray locking mechanism instead big devlink lock Leon Romanovsky
2021-12-05 8:22 ` [PATCH net-next 6/6] devlink: Open devlink to parallel operations Leon Romanovsky
2021-12-07 2:00 ` [PATCH net-next 0/6] Allow parallel devlink execution Jakub Kicinski
2021-12-07 7:29 ` Leon Romanovsky [this message]
2021-12-08 4:21 ` Jakub Kicinski
2021-12-08 7:54 ` Leon Romanovsky
2021-12-08 15:15 ` Jakub Kicinski
2021-12-08 19:38 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya8NPxxn8/OAF4cR@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).