From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD81C433EF for ; Tue, 7 Dec 2021 14:53:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238273AbhLGO5S (ORCPT ); Tue, 7 Dec 2021 09:57:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238271AbhLGO5R (ORCPT ); Tue, 7 Dec 2021 09:57:17 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80F9EC061574 for ; Tue, 7 Dec 2021 06:53:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qEtHhJBLQ9ZROQ9PQxUStiU/tLhXm6fnS3cSVeD+HRk=; b=V0xXrfZt6Lz2+jCPPo/oYUbrFe x4m/Dc+Kfr08OXEYp3cgSjJlDKa0K1Dq/wKyr66M1A7gxSdXv62VwsZMMVM9qzbVDHf0sGeu9TbLo 7w6D02CY8Eft2MQekhDxomDX1yVPoeC/1oENMRVRARFxZPDNYN+NnJUQipsutvAIhC/MEcGyg1irM lmvT2W4TjTs3D5r5M4rnqct+nAJQYe+ZwYdC60UtmiPJ/ogNojInLWe3QJ+RG1TTDK9diRitRS9JR Viy5ZxFeAhYBjiu/RRgaJ4eaYNKCdtrKru+C45PhR7hm1ltGPQMVXAABTyS75blMV3ftsUtP5Px3X D+bMFw5A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56160) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mubqj-0006KN-0t; Tue, 07 Dec 2021 14:53:45 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mubqi-0005QB-3E; Tue, 07 Dec 2021 14:53:44 +0000 Date: Tue, 7 Dec 2021 14:53:44 +0000 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: Martyn Welch , Andrew Lunn , Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, kernel@collabora.com Subject: Re: mv88e6240 configuration broken for B850v3 Message-ID: References: <20211206202308.xoutfymjozfyhhkl@skbuf> <20211206211341.ppllxa7ve2jdyzt4@skbuf> <20211206232735.vvjgm664y67nggmm@skbuf> <20211207132413.f4av4d3expfzhnwl@skbuf> <20211207143705.46fd2zavniwb3gri@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211207143705.46fd2zavniwb3gri@skbuf> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Dec 07, 2021 at 04:37:05PM +0200, Vladimir Oltean wrote: > Although it isn't strictly true that "[ if ] there is a non-software > method to handle the status updates, then we don't do any forcing in > the mac_link_*() methods", because technically we still do in > mac_link_down, due to the " || mode == MLO_AN_FIXED" condition plus the > way in which we are called, it's just that we undo it later. Fixed links are a "software method" as Andrew has already pointed out - there is a software hook that can be used to retrieve the link status, potentially also updating the other link parameters as well. Fixed links have never been "these are the only parameters you will ever get and the link will always be forced up". That is not new. Have a look at drivers/net/phy/fixed_phy.c and its link_update() method, which can change any parameter of the fixed-link it desires. There is also fixed_phy_change_carrier() which allows one to force the link state of a fixed-link. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!